Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12775

Reuse data type aggregation code for hybrid functions and UNION

Details

    Description

      Currently we have two versions of data type attribute aggregation code:

      • For hybrid functions, implemented in Type_handler::Item_hybrid_func_fix_attributes()
      • For UNION, implemented in Item_type_holder::join_types()

      Both versions do the same thing, but in some cases UNION is not precise enough.
      See bugs: MDEV-9495, MDEV-9497, MDEV-12594, MDEV-12595, MDEV-12599.

      Under terms of this task we'll make the UNION related code reuse the code implemented in Type_handler::Item_hybrid_func_fix_attributes() and get rid of the second implementation in Item_type_holder::join_types().

      This, among fixing the mentioned bugs, will simplify development of data type plugins, as the implementer will have to do less coding.

      Attachments

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-4912 Data type plugin API version 1

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-9495 Wrong field type for a UNION of a signed and an unsigned INT expression

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-9497 UNION and COALESCE produce different field types for DECIMAL+INT

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12594 UNION between fixed length double columns does not always preserve scale

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12595 UNION converts INT to BIGINT

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12599 UNION is not symmetric when mixing INT and CHAR

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-9234 Add Type_handler::union_element_finalize()

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21662 UNION to sub-query with constant NULL incorrectly cast unsigned INT to DECIMAL(48,38)

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24387 Wrong number of decimal digits in certain UNION/Subqery constellation

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            sanja Oleksandr Byelkin added a comment -

            ok to push

            sanja Oleksandr Byelkin added a comment - ok to push
            bar Alexander Barkov added a comment -

            Pushed to bb-10.2-ext.

            bar Alexander Barkov added a comment - Pushed to bb-10.2-ext.

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.