Uploaded image for project: 'MariaDB ColumnStore'
  1. MariaDB ColumnStore
  2. MCOL-3638

StorageManager logging inconsistency

    XMLWordPrintable

    Details

    • Sprint:
      2020-1, 2020-2

      Description

      Noticed what is likely a cut & paste error. Need to skim the S3Storage class at least, and make sure log msgs are going to the right place. Ex:

      {{ if (ms3_server_error(creds))
      logger->log(LOG_WARNING, "S3Storage::putObject(): failed to PUT, server says '%s'. bucket = %s, key = %s.",
      ms3_server_error(creds), bucket.c_str(), destKey.c_str());
      else
      logger->log(LOG_ERR, "S3Storage::putObject(): failed to PUT, got '%s'. bucket = %s, key = %s.",
      s3err_msgs[s3err], bucket.c_str(), destKey.c_str());}}

      I can't think of a reason one should go to warning, one should go to err, it's the same error msg.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dleeyh Daniel Lee
              Reporter:
              pleblanc Patrick LeBlanc (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.