[MCOL-3638] StorageManager logging inconsistency Created: 2019-12-02  Updated: 2020-03-13  Resolved: 2020-02-12

Status: Closed
Project: MariaDB ColumnStore
Component/s: Storage Manager
Affects Version/s: 1.4.0
Fix Version/s: 1.4.3

Type: Bug Priority: Major
Reporter: Patrick LeBlanc (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MCOL-3494 S3 When postConfigure failed to acces... Closed
Sprint: 2020-1, 2020-2

 Description   

Noticed what is likely a cut & paste error. Need to skim the S3Storage class at least, and make sure log msgs are going to the right place. Ex:

{{ if (ms3_server_error(creds))
logger->log(LOG_WARNING, "S3Storage::putObject(): failed to PUT, server says '%s'. bucket = %s, key = %s.",
ms3_server_error(creds), bucket.c_str(), destKey.c_str());
else
logger->log(LOG_ERR, "S3Storage::putObject(): failed to PUT, got '%s'. bucket = %s, key = %s.",
s3err_msgs[s3err], bucket.c_str(), destKey.c_str());}}

I can't think of a reason one should go to warning, one should go to err, it's the same error msg.

 Comments   
Comment by Patrick LeBlanc (Inactive) [ 2019-12-30 ]

approved the PR, will merge when unfrozen.

Comment by Patrick LeBlanc (Inactive) [ 2020-01-03 ]

Merged it.

Daniel, to verify this one, you would just need to look at the log files and give your opinion on whether msgs from storagemanager are at the appropriate log level or not. Subjective test.

Comment by Daniel Lee (Inactive) [ 2020-02-12 ]

Build verified: 1.4.3-1 source
server
commit cbfa2cfc48da12a13957d06c59e6a7651b77aa6a
engine
commit cf668897eff4395cc929abffb0cd87df0305c88b

Compare logs files from both 1.4.2 and 1.4.3. I did not noticed much difference between the two except messages relating to MCOL-3748.

Generated at Thu Feb 08 02:44:19 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.