Type:
Task
Priority:
Major
Resolution:
Fixed
Passing data in sql_yacc.yy through LEX members is hard to follow and is not recursively safe.
We'll get rid of LEX::length and LEX::dec and add a structure instead:
struct Lex_length_and_dec_st
{
const char *length;
const char *dec;
};
so it can be passed through the syntax rules in sql_yacc.yy as $$, $1, $2, etc.
This will help, for example, to change:
field_spec:
field_ident { /* new Create_field is allocated here */}
field_type { Lex->set_last_field_type($3); }
field_def { ... }
;
into:
field_spec:
field_ident field_type { /* new Create field is allocated here*/ }
field_def { ... }
So we'll already know data type, length and dec when we do "new Create_field".
This will allow to call a method in Type_handler, to create a data-type specific "Create_field" replacement, instead of using the generic universal Create_field.
blocks
MDEV-4912
Data type plugin API version 1
Closed
There are no comments yet on this issue.
{"report":{"fcp":1742.3999998569489,"ttfb":270.09999990463257,"pageVisibility":"visible","entityId":54304,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"aad2cada-d356-43b5-a215-ddede83104d0","navigationType":0,"readyForUser":1847.5,"redirectCount":0,"resourceLoadedEnd":1272.7000000476837,"resourceLoadedStart":280.5,"resourceTiming":[{"duration":161.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":280.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":280.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":442,"responseStart":0,"secureConnectionStart":0},{"duration":181.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":281.2999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":281.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":462.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":731.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":281.89999985694885,"connectEnd":281.89999985694885,"connectStart":281.89999985694885,"domainLookupEnd":281.89999985694885,"domainLookupStart":281.89999985694885,"fetchStart":281.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":476.2999999523163,"responseEnd":1013.2999999523163,"responseStart":599.7999999523163,"secureConnectionStart":281.89999985694885},{"duration":956.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":282.2999999523163,"connectEnd":282.2999999523163,"connectStart":282.2999999523163,"domainLookupEnd":282.2999999523163,"domainLookupStart":282.2999999523163,"fetchStart":282.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":476.5,"responseEnd":1239.2000000476837,"responseStart":602.2000000476837,"secureConnectionStart":282.2999999523163},{"duration":316.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":282.7000000476837,"connectEnd":282.7000000476837,"connectStart":282.7000000476837,"domainLookupEnd":282.7000000476837,"domainLookupStart":282.7000000476837,"fetchStart":282.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":476.59999990463257,"responseEnd":598.8999998569489,"responseStart":596.7999999523163,"secureConnectionStart":282.7000000476837},{"duration":315.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":283.39999985694885,"connectEnd":283.39999985694885,"connectStart":283.39999985694885,"domainLookupEnd":283.39999985694885,"domainLookupStart":283.39999985694885,"fetchStart":283.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":476.59999990463257,"responseEnd":598.7999999523163,"responseStart":582.5999999046326,"secureConnectionStart":283.39999985694885},{"duration":265.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":330.2000000476837,"connectEnd":330.2000000476837,"connectStart":330.2000000476837,"domainLookupEnd":330.2000000476837,"domainLookupStart":330.2000000476837,"fetchStart":330.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":476.7999999523163,"responseEnd":595.2999999523163,"responseStart":579,"secureConnectionStart":330.2000000476837},{"duration":136.70000004768372,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":331.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":331.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":467.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":262.89999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":331.5,"connectEnd":331.5,"connectStart":331.5,"domainLookupEnd":331.5,"domainLookupStart":331.5,"fetchStart":331.5,"redirectEnd":0,"redirectStart":0,"requestStart":477.5,"responseEnd":594.3999998569489,"responseStart":577.2000000476837,"secureConnectionStart":331.5},{"duration":137,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":332.2000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":332.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":469.2000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":282.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":332.5,"connectEnd":332.5,"connectStart":332.5,"domainLookupEnd":332.5,"domainLookupStart":332.5,"fetchStart":332.5,"redirectEnd":0,"redirectStart":0,"requestStart":477.59999990463257,"responseEnd":614.5999999046326,"responseStart":596,"secureConnectionStart":332.5},{"duration":893.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":369.7999999523163,"connectEnd":369.7999999523163,"connectStart":369.7999999523163,"domainLookupEnd":369.7999999523163,"domainLookupStart":369.7999999523163,"fetchStart":369.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":587,"responseEnd":1263.0999999046326,"responseStart":1251,"secureConnectionStart":369.7999999523163},{"duration":902.8000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":369.89999985694885,"connectEnd":369.89999985694885,"connectStart":369.89999985694885,"domainLookupEnd":369.89999985694885,"domainLookupStart":369.89999985694885,"fetchStart":369.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":598.2000000476837,"responseEnd":1272.7000000476837,"responseStart":1257.2999999523163,"secureConnectionStart":369.89999985694885},{"duration":174.20000004768372,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1179.3999998569489,"connectEnd":1179.3999998569489,"connectStart":1179.3999998569489,"domainLookupEnd":1179.3999998569489,"domainLookupStart":1179.3999998569489,"fetchStart":1179.3999998569489,"redirectEnd":0,"redirectStart":0,"requestStart":1319.7999999523163,"responseEnd":1353.5999999046326,"responseStart":1352.5999999046326,"secureConnectionStart":1179.3999998569489},{"duration":144,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1649.2999999523163,"connectEnd":1649.2999999523163,"connectStart":1649.2999999523163,"domainLookupEnd":1649.2999999523163,"domainLookupStart":1649.2999999523163,"fetchStart":1649.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":1762.8999998569489,"responseEnd":1793.2999999523163,"responseStart":1792,"secureConnectionStart":1649.2999999523163},{"duration":188.70000004768372,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1736,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1736,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1924.7000000476837,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":115,"responseStart":270,"responseEnd":290,"domLoading":277,"domInteractive":1960,"domContentLoadedEventStart":1960,"domContentLoadedEventEnd":2026,"domComplete":2209,"loadEventStart":2209,"loadEventEnd":2210,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1932},{"name":"bigPipe.sidebar-id.end","time":1934.7999999523163},{"name":"bigPipe.activity-panel-pipe-id.start","time":1935},{"name":"bigPipe.activity-panel-pipe-id.end","time":1935.5},{"name":"activityTabFullyLoaded","time":2042.7999999523163}],"measures":[],"correlationId":"73f314bcc5a07e","effectiveType":"4g","downlink":9,"rtt":0,"serverDuration":88,"dbReadsTimeInMs":10,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}