[MDEV-8644] Using a UDF in a virtual column causes a crash when stopping the server - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 5.5(EOL), 10.0(EOL), 10.1(EOL)
Fix Version/s: 5.5.47, 10.0.23, 10.1.10
Component/s: Virtual Columns
Labels:
- UDF
- Virtual

Description

Because MariaDB does not accept a constant virtual column (other DBMS's do) I was obliged to write the noconst UDF as:

/***********************************************************************/

/*  Returns its argument saying it is not a constant.                  */

/***********************************************************************/

my_bool noconst_init(UDF_INIT *initid, UDF_ARGS *args, char *message)

	if (args->arg_count != 1 || args->arg_type[0] != STRING_RESULT) {

		strcpy(message, "noconst unique argument must be a string");

		return true;

	} // endif arg

	initid->const_item = false;    // The trick!

	return false;

} // end of noconst_init

char *noconst(UDF_INIT *initid, UDF_ARGS *args, char *result,

	unsigned long *res_length, char *, char *)

	return args->args[0];

} // end of noconst

Now, creating the table t1, inserting one line to it and displaying it does work:

MariaDB [test]> create table t1 (

    -> n int key not null auto_increment,

    -> msg char(20) as (noconst('Hello World')) virtual);

Query OK, 0 rows affected (0.06 sec)

MariaDB [test]> insert into t1() values();

Query OK, 1 row affected (0.01 sec)

MariaDB [test]> select * from t1;

+---+-------------+

| n | msg         |

+---+-------------+

| 1 | Hello World |

+---+-------------+

1 row in set (0.00 sec)

However, later on when stopping the server a crash occurs in the function:

void udf_handler::cleanup()

  if (!not_original)

    if (initialized)

      if (u_d->func_deinit != NULL)

        Udf_func_deinit deinit= u_d->func_deinit;

        (*deinit)(&initid);

      free_udf(u_d);

      initialized= FALSE;

    if (buffers)				// Because of bug in ecc

      delete [] buffers;

    buffers= 0;

See the attach udf_crash.log.
The same kind of crash occurs with different other UDF's.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

noconst.c
1 kB
2015-08-18 21:24
udf_crash.log
3 kB
2015-08-18 19:10

Activity

Ascending order - Click to sort in descending order

Olivier Bertrand created issue - 2015-08-18 19:12

Olivier Bertrand made changes - 2015-08-18 19:19

Field	Original Value	New Value
Description	Because MariaDB does not accept a constant virtual column (other DBMS's do) I was obliged to write the noconst UDF as: {code} /**********************************************************************/ / Returns its argument saying it is not a constant. / /*********************************************************************/ my_bool noconst_init(UDF_INIT initid, UDF_ARGS args, char message) { if (args->arg_count != 1) { strcpy(message, "noconst accepts only 1 argument"); return true; } else if (args->arg_type[0] != STRING_RESULT) { strcpy(message, "noconst first argument must be a string"); return true; } // endif arg initid->const_item = false; return false; } // end of noconst_init char noconst(UDF_INIT initid, UDF_ARGS args, char result, unsigned long res_length, char , char ) { res_length = args->lengths[0]; return args->args[0]; } // end of noconst void noconst_deinit(UDF_INIT* initid) { } // end of noconst_deinit {code} No creating the table vjs, inserting one line to it and displaying it does work: {code} MariaDB [test]> create table t1 ( -> n int key not null auto_increment, -> msg char(20) as (noconst('Hello World')) virtual); Query OK, 0 rows affected (0.06 sec) MariaDB [test]> insert into t1() values(); Query OK, 1 row affected (0.01 sec) MariaDB [test]> select * from t1; +---+-------------+ \| n \| msg \| +---+-------------+ \| 1 \| Hello World \| +---+-------------+ 1 row in set (0.00 sec) {code} However when stopping the server late on a crash occurs in the function: {code} void udf_handler::cleanup() { if (!not_original) { if (initialized) { if (u_d->func_deinit != NULL) { Udf_func_deinit deinit= u_d->func_deinit; (*deinit)(&initid); } free_udf(u_d); initialized= FALSE; } if (buffers) // Because of bug in ecc delete [] buffers; buffers= 0; } } {code} See the attach udf_crash.log	Because MariaDB does not accept a constant virtual column (other DBMS's do) I was obliged to write the noconst UDF as: {code} /**********************************************************************/ / Returns its argument saying it is not a constant. / /*********************************************************************/ my_bool noconst_init(UDF_INIT initid, UDF_ARGS args, char message) { if (args->arg_count != 1) { strcpy(message, "noconst accepts only 1 argument"); return true; } else if (args->arg_type[0] != STRING_RESULT) { strcpy(message, "noconst first argument must be a string"); return true; } // endif arg initid->const_item = false; return false; } // end of noconst_init char noconst(UDF_INIT initid, UDF_ARGS args, char result, unsigned long res_length, char , char ) { res_length = args->lengths[0]; return args->args[0]; } // end of noconst void noconst_deinit(UDF_INIT* initid) { } // end of noconst_deinit {code} Now, creating the table t1, inserting one line to it and displaying it does work: {code} MariaDB [test]> create table t1 ( -> n int key not null auto_increment, -> msg char(20) as (noconst('Hello World')) virtual); Query OK, 0 rows affected (0.06 sec) MariaDB [test]> insert into t1() values(); Query OK, 1 row affected (0.01 sec) MariaDB [test]> select * from t1; +---+-------------+ \| n \| msg \| +---+-------------+ \| 1 \| Hello World \| +---+-------------+ 1 row in set (0.00 sec) {code} However, later on when stopping the server a crash occurs in the function: {code} void udf_handler::cleanup() { if (!not_original) { if (initialized) { if (u_d->func_deinit != NULL) { Udf_func_deinit deinit= u_d->func_deinit; (*deinit)(&initid); } free_udf(u_d); initialized= FALSE; } if (buffers) // Because of bug in ecc delete [] buffers; buffers= 0; } } {code} See the attach udf_crash.log. The same kind of crash occurs with different other UDF's.

Olivier Bertrand made changes - 2015-08-18 19:38

Description

Because MariaDB does not accept a constant virtual column (other DBMS's do) I was obliged to write the noconst UDF as:
{code}
/***********************************************************************/
/* Returns its argument saying it is not a constant. */
/***********************************************************************/
my_bool noconst_init(UDF_INIT *initid, UDF_ARGS *args, char *message)
{
if (args->arg_count != 1) {
strcpy(message, "noconst accepts only 1 argument");
return true;
} else if (args->arg_type[0] != STRING_RESULT) {
strcpy(message, "noconst first argument must be a string");
return true;
} // endif arg

initid->const_item = false;
return false;
} // end of noconst_init

char *noconst(UDF_INIT *initid, UDF_ARGS *args, char *result,
unsigned long *res_length, char *, char *)
{
*res_length = args->lengths[0];
return args->args[0];
} // end of noconst

void noconst_deinit(UDF_INIT* initid)
{
} // end of noconst_deinit
{code}
Now, creating the table t1, inserting one line to it and displaying it does work:
{code}
MariaDB [test]> create table t1 (
    -> n int key not null auto_increment,
    -> msg char(20) as (noconst('Hello World')) virtual);
Query OK, 0 rows affected (0.06 sec)

MariaDB [test]> insert into t1() values();
Query OK, 1 row affected (0.01 sec)

MariaDB [test]> select * from t1;
+---+-------------+
| n | msg |
+---+-------------+
| 1 | Hello World |
+---+-------------+
1 row in set (0.00 sec)
{code}
However, later on when stopping the server a crash occurs in the function:
{code}
void udf_handler::cleanup()
{
  if (!not_original)
  {
    if (initialized)
    {
      if (u_d->func_deinit != NULL)
      {
        Udf_func_deinit deinit= u_d->func_deinit;
        (*deinit)(&initid);
      }
      free_udf(u_d);
      initialized= FALSE;
    }
    if (buffers) // Because of bug in ecc
      delete [] buffers;
    buffers= 0;
  }
}
{code}
See the attach udf_crash.log.
The same kind of crash occurs with different other UDF's.

Because MariaDB does not accept a constant virtual column (other DBMS's do) I was obliged to write the noconst UDF as:
{code}
/***********************************************************************/
/* Returns its argument saying it is not a constant. */
/***********************************************************************/
my_bool noconst_init(UDF_INIT *initid, UDF_ARGS *args, char *message)
{
if (args->arg_count != 1 || args->arg_type[0] != STRING_RESULT) {
strcpy(message, "noconst unique argument must be a string");
return true;
} // endif arg

initid->const_item = false;
return false;
} // end of noconst_init

char *noconst(UDF_INIT *initid, UDF_ARGS *args, char *result,
unsigned long *res_length, char *, char *)
{
*res_length = args->lengths[0];
return args->args[0];
} // end of noconst
{code}
Now, creating the table t1, inserting one line to it and displaying it does work:
{code}
MariaDB [test]> create table t1 (
    -> n int key not null auto_increment,
    -> msg char(20) as (noconst('Hello World')) virtual);
Query OK, 0 rows affected (0.06 sec)

MariaDB [test]> insert into t1() values();
Query OK, 1 row affected (0.01 sec)

MariaDB [test]> select * from t1;
+---+-------------+
| n | msg |
+---+-------------+
| 1 | Hello World |
+---+-------------+
1 row in set (0.00 sec)
{code}
However, later on when stopping the server a crash occurs in the function:
{code}
void udf_handler::cleanup()
{
  if (!not_original)
  {
    if (initialized)
    {
      if (u_d->func_deinit != NULL)
      {
        Udf_func_deinit deinit= u_d->func_deinit;
        (*deinit)(&initid);
      }
      free_udf(u_d);
      initialized= FALSE;
    }
    if (buffers) // Because of bug in ecc
      delete [] buffers;
    buffers= 0;
  }
}
{code}
See the attach udf_crash.log.
The same kind of crash occurs with different other UDF's.

Olivier Bertrand made changes - 2015-08-18 19:41

Description

Because MariaDB does not accept a constant virtual column (other DBMS's do) I was obliged to write the noconst UDF as:
{code}
/***********************************************************************/
/* Returns its argument saying it is not a constant. */
/***********************************************************************/
my_bool noconst_init(UDF_INIT *initid, UDF_ARGS *args, char *message)
{
if (args->arg_count != 1 || args->arg_type[0] != STRING_RESULT) {
strcpy(message, "noconst unique argument must be a string");
return true;
} // endif arg

initid->const_item = false;
return false;
} // end of noconst_init

char *noconst(UDF_INIT *initid, UDF_ARGS *args, char *result,
unsigned long *res_length, char *, char *)
{
*res_length = args->lengths[0];
return args->args[0];
} // end of noconst
{code}
Now, creating the table t1, inserting one line to it and displaying it does work:
{code}
MariaDB [test]> create table t1 (
    -> n int key not null auto_increment,
    -> msg char(20) as (noconst('Hello World')) virtual);
Query OK, 0 rows affected (0.06 sec)

MariaDB [test]> insert into t1() values();
Query OK, 1 row affected (0.01 sec)

MariaDB [test]> select * from t1;
+---+-------------+
| n | msg |
+---+-------------+
| 1 | Hello World |
+---+-------------+
1 row in set (0.00 sec)
{code}
However, later on when stopping the server a crash occurs in the function:
{code}
void udf_handler::cleanup()
{
  if (!not_original)
  {
    if (initialized)
    {
      if (u_d->func_deinit != NULL)
      {
        Udf_func_deinit deinit= u_d->func_deinit;
        (*deinit)(&initid);
      }
      free_udf(u_d);
      initialized= FALSE;
    }
    if (buffers) // Because of bug in ecc
      delete [] buffers;
    buffers= 0;
  }
}
{code}
See the attach udf_crash.log.
The same kind of crash occurs with different other UDF's.

Because MariaDB does not accept a constant virtual column (other DBMS's do) I was obliged to write the noconst UDF as:
{code}
/***********************************************************************/
/* Returns its argument saying it is not a constant. */
/***********************************************************************/
my_bool noconst_init(UDF_INIT *initid, UDF_ARGS *args, char *message)
{
if (args->arg_count != 1 || args->arg_type[0] != STRING_RESULT) {
strcpy(message, "noconst unique argument must be a string");
return true;
} // endif arg

initid->const_item = false;
return false;
} // end of noconst_init

char *noconst(UDF_INIT *initid, UDF_ARGS *args, char *result,
unsigned long *res_length, char *, char *)
{
return args->args[0];
} // end of noconst
{code}
Now, creating the table t1, inserting one line to it and displaying it does work:
{code}
MariaDB [test]> create table t1 (
    -> n int key not null auto_increment,
    -> msg char(20) as (noconst('Hello World')) virtual);
Query OK, 0 rows affected (0.06 sec)

MariaDB [test]> insert into t1() values();
Query OK, 1 row affected (0.01 sec)

MariaDB [test]> select * from t1;
+---+-------------+
| n | msg |
+---+-------------+
| 1 | Hello World |
+---+-------------+
1 row in set (0.00 sec)
{code}
However, later on when stopping the server a crash occurs in the function:
{code}
void udf_handler::cleanup()
{
  if (!not_original)
  {
    if (initialized)
    {
      if (u_d->func_deinit != NULL)
      {
        Udf_func_deinit deinit= u_d->func_deinit;
        (*deinit)(&initid);
      }
      free_udf(u_d);
      initialized= FALSE;
    }
    if (buffers) // Because of bug in ecc
      delete [] buffers;
    buffers= 0;
  }
}
{code}
See the attach udf_crash.log.
The same kind of crash occurs with different other UDF's.

Olivier Bertrand made changes - 2015-08-18 19:56

Description

Because MariaDB does not accept a constant virtual column (other DBMS's do) I was obliged to write the noconst UDF as:
{code}
/***********************************************************************/
/* Returns its argument saying it is not a constant. */
/***********************************************************************/
my_bool noconst_init(UDF_INIT *initid, UDF_ARGS *args, char *message)
{
if (args->arg_count != 1 || args->arg_type[0] != STRING_RESULT) {
strcpy(message, "noconst unique argument must be a string");
return true;
} // endif arg

initid->const_item = false;
return false;
} // end of noconst_init

char *noconst(UDF_INIT *initid, UDF_ARGS *args, char *result,
unsigned long *res_length, char *, char *)
{
return args->args[0];
} // end of noconst
{code}
Now, creating the table t1, inserting one line to it and displaying it does work:
{code}
MariaDB [test]> create table t1 (
    -> n int key not null auto_increment,
    -> msg char(20) as (noconst('Hello World')) virtual);
Query OK, 0 rows affected (0.06 sec)

MariaDB [test]> insert into t1() values();
Query OK, 1 row affected (0.01 sec)

MariaDB [test]> select * from t1;
+---+-------------+
| n | msg |
+---+-------------+
| 1 | Hello World |
+---+-------------+
1 row in set (0.00 sec)
{code}
However, later on when stopping the server a crash occurs in the function:
{code}
void udf_handler::cleanup()
{
  if (!not_original)
  {
    if (initialized)
    {
      if (u_d->func_deinit != NULL)
      {
        Udf_func_deinit deinit= u_d->func_deinit;
        (*deinit)(&initid);
      }
      free_udf(u_d);
      initialized= FALSE;
    }
    if (buffers) // Because of bug in ecc
      delete [] buffers;
    buffers= 0;
  }
}
{code}
See the attach udf_crash.log.
The same kind of crash occurs with different other UDF's.

Because MariaDB does not accept a constant virtual column (other DBMS's do) I was obliged to write the noconst UDF as:
{code}
/***********************************************************************/
/* Returns its argument saying it is not a constant. */
/***********************************************************************/
my_bool noconst_init(UDF_INIT *initid, UDF_ARGS *args, char *message)
{
if (args->arg_count != 1 || args->arg_type[0] != STRING_RESULT) {
strcpy(message, "noconst unique argument must be a string");
return true;
} // endif arg

initid->const_item = false; // The trick!
return false;
} // end of noconst_init

char *noconst(UDF_INIT *initid, UDF_ARGS *args, char *result,
unsigned long *res_length, char *, char *)
{
return args->args[0];
} // end of noconst
{code}
Now, creating the table t1, inserting one line to it and displaying it does work:
{code}
MariaDB [test]> create table t1 (
    -> n int key not null auto_increment,
    -> msg char(20) as (noconst('Hello World')) virtual);
Query OK, 0 rows affected (0.06 sec)

MariaDB [test]> insert into t1() values();
Query OK, 1 row affected (0.01 sec)

MariaDB [test]> select * from t1;
+---+-------------+
| n | msg |
+---+-------------+
| 1 | Hello World |
+---+-------------+
1 row in set (0.00 sec)
{code}
However, later on when stopping the server a crash occurs in the function:
{code}
void udf_handler::cleanup()
{
  if (!not_original)
  {
    if (initialized)
    {
      if (u_d->func_deinit != NULL)
      {
        Udf_func_deinit deinit= u_d->func_deinit;
        (*deinit)(&initid);
      }
      free_udf(u_d);
      initialized= FALSE;
    }
    if (buffers) // Because of bug in ecc
      delete [] buffers;
    buffers= 0;
  }
}
{code}
See the attach udf_crash.log.
The same kind of crash occurs with different other UDF's.

Elena Stepanova made changes - 2015-08-18 20:05

Labels

UDF Virtual

UDF Virtual need_feedback

Olivier Bertrand made changes - 2015-08-18 21:24

Attachment

noconst.c [ 39205 ]

Elena Stepanova made changes - 2015-09-16 01:17

Labels

UDF Virtual need_feedback

UDF Virtual

Elena Stepanova made changes - 2015-09-16 02:58

Status

Open [ 1 ]

Confirmed [ 10101 ]

Elena Stepanova made changes - 2015-09-16 03:00

Component/s		OTHER [ 10125 ]
Fix Version/s		10.1 [ 16100 ]
Fix Version/s		10.0 [ 16000 ]
Fix Version/s		5.5 [ 15800 ]
Affects Version/s		10.1 [ 16100 ]
Affects Version/s		10.0 [ 16000 ]
Affects Version/s		5.5 [ 15800 ]
Affects Version/s	10.1.5 [ 18813 ]
Assignee		Sergei Golubchik [ serg ]
Environment	Windows 7

Sergei Golubchik made changes - 2015-09-19 11:46

Component/s

OTHER [ 10125 ]

Sergei Golubchik made changes - 2015-12-06 13:05

Summary

Using an UDF in a virtual column causes a crash when stopping the server

Using a UDF in a virtual column causes a crash when stopping the server

Sergei Golubchik made changes - 2015-12-06 14:58

Status

Confirmed [ 10101 ]

In Progress [ 3 ]

Sergei Golubchik made changes - 2015-12-06 15:14

Status

In Progress [ 3 ]

Stalled [ 10000 ]

Sergei Golubchik made changes - 2015-12-06 15:14

Assignee

Sergei Golubchik [ serg ]

Elena Stepanova [ elenst ]

Elena Stepanova made changes - 2015-12-06 18:25

Assignee

Elena Stepanova [ elenst ]

Sergei Golubchik [ serg ]

Sergei Golubchik made changes - 2015-12-07 15:22

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Sergei Golubchik made changes - 2015-12-08 12:05

Fix Version/s		5.5.47 [ 20300 ]
Fix Version/s		10.0.23 [ 20401 ]
Fix Version/s		10.1.10 [ 20402 ]
Fix Version/s	5.5 [ 15800 ]
Fix Version/s	10.0 [ 16000 ]
Fix Version/s	10.1 [ 16100 ]
Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Closed [ 6 ]

Sergei Golubchik made changes - 2021-12-06 21:41

Workflow

MariaDB v3 [ 71129 ]

MariaDB v4 [ 149489 ]

People

Assignee:: Sergei Golubchik

Reporter:: Olivier Bertrand

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2015-08-18 19:12

Updated:: 2015-12-08 14:57

Resolved:: 2015-12-08 12:05

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Attachments

Activity

People

Dates

Git Integration