Details
-
Bug
-
Status: Stalled (View Workflow)
-
Critical
-
Resolution: Unresolved
-
5.5(EOL), 10.0(EOL), 10.1(EOL), 10.5, 10.6, 10.11, 11.4
Description
When making a dump with --dump-slave option, upon completion mysqldump starts slave threads even if they were not stopped by mysqldump itself. This behavior breaks delayed/manually synchronized slaves which have not to be running all the time. Please consider implementing additional check(s) for that, like in the attached patch.
P.S. The comment /* if SLAVE SQL is not running, we don't start it */ in do_start_slave_sql() is opposite and misleading.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description | When making a dump with --dump-slave option, upon completion mysqldump starts slave threads even if they were not stopped by mysqldump itself. This behavior breaks delayed/manually synchronized slaves which have not be running all the time. Please consider implementing additional check(s) for that, like in the attached patch. |
When making a dump with --dump-slave option, upon completion mysqldump starts slave threads even if they were not stopped by mysqldump itself. This behavior breaks delayed/manually synchronized slaves which have not to be running all the time. Please consider implementing additional check(s) for that, like in the attached patch. P.S. The comment /* if SLAVE SQL is not running, we don't start it */ in do_start_slave_sql() is opposite and misleading. |
| Component/s | OTHER [ 10125 ] | |
| Fix Version/s | 10.0 [ 16000 ] | |
| Fix Version/s | 5.5 [ 15800 ] | |
| Affects Version/s | 10.0 [ 16000 ] | |
| Affects Version/s | 5.5 [ 15800 ] | |
| Affects Version/s | 10.0.16 [ 17900 ] | |
| Labels | upstream verified | |
| Priority | Trivial [ 5 ] | Minor [ 4 ] |
| Summary | mysqldump --dump-slave always starts stopped slave | [PATCH] mysqldump --dump-slave always starts stopped slave |
| Remote Link | This issue links to "Bug #64390 - mysqldump should not restart slave automatically (Web Link)" [ 22502 ] |
| Assignee | Sergei Golubchik [ serg ] |
| Workflow | MariaDB v2 [ 59725 ] | MariaDB v3 [ 65759 ] |
| Workflow | MariaDB v3 [ 65759 ] | MariaDB v4 [ 139772 ] |
| Fix Version/s | 10.0 [ 16000 ] |
I think this is not an upstream bug anymore.
Can it be fixed in mariadb-dump now?
| Affects Version/s | 10.1(EOL) [ 16100 ] | |
| Affects Version/s | 10.5 [ 23123 ] | |
| Affects Version/s | 10.6 [ 24028 ] | |
| Affects Version/s | 10.11 [ 27614 ] | |
| Affects Version/s | 11.4 [ 29301 ] |
| Fix Version/s | 10.6 [ 24028 ] | |
| Fix Version/s | 10.11 [ 27614 ] | |
| Fix Version/s | 11.4 [ 29301 ] |
| Priority | Minor [ 4 ] | Major [ 3 ] |
| Priority | Major [ 3 ] | Critical [ 2 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | In Review [ 10002 ] |
| Fix Version/s | 5.5(EOL) [ 15800 ] |
Thanks. The patch is fine. It lacks a test case, but we can add it, don't bother.
bnestere, could you check the whole idea once again? Is it the behavior we want to have?
| Assignee | Sergei Golubchik [ serg ] | Brandon Nesterenko [ JIRAUSER48702 ] |
Seems good to me. ParadoxV5, this is a good opportunity to learn a bit about mysqldump. Can you take over for the patch, and create the test case?
| Assignee | Brandon Nesterenko [ JIRAUSER48702 ] | Jimmy Hú [ JIRAUSER55761 ] |
Not good.
It cannot be a single global boolean for multi-source replication (est. MariaDB 10.0).
/* Loop over all slaves */ |
while ((row= mysql_fetch_row(slave))) |
This patch (made for 5.5, I presume) is outdated.
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
| Status | Stalled [ 10000 ] | In Progress [ 3 ] |
https://github.com/MariaDB/server/pull/3780
I have a question about our internal APIs.
The rest are ready for review in the meantime.
| Assignee | Jimmy Hú [ JIRAUSER55761 ] | Brandon Nesterenko [ JIRAUSER48702 ] |
| Status | In Progress [ 3 ] | In Review [ 10002 ] |
| Component/s | Replication [ 10100 ] |
| Assignee | Brandon Nesterenko [ JIRAUSER48702 ] | Jimmy Hú [ JIRAUSER55761 ] |
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
smax,
Thanks for the report and the patch.
serg,
Technically it's an upstream bug, but it's been in 'verified' for 3 years with no progress, maybe it makes sense not to wait and just to apply the patch?