Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-6178

[PATCH] mysql_upgrade breaks databases with long user names

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 5.5.37, 10.0.10
    • 5.5.38, 10.0.11
    • None
    • None

    Description

      mysql_upgrade is supposed to be a no-op on databases that are fully upgraded already. But scripts/mysql_system_tables_fix.sql has lots of old statements including those that try to modify User column in different tables to be char(16) instead of char(80). That breaks databases that already have users with names longer than 16 characters.

      In the attachment is a patch that fixes the problem (with a test).

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-4332 Increase username length from 16 characters

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-6068 Upgrade removes all changes to 'mysql' database

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            elenst Elena Stepanova added a comment -

            Hi Pavel,
            Thanks.

            The bug has been already fixed by this commit: http://bazaar.launchpad.net/~maria-captains/maria/10.0/revision/4148 (there were a couple more lines that needed fixing).
            And we also have the open task MDEV-6069 to remove redundant ALTERs from the script.

            However, there was no test in that commit, which of course is wrong. Thanks for providing one.

            elenst Elena Stepanova added a comment - Hi Pavel, Thanks. The bug has been already fixed by this commit: http://bazaar.launchpad.net/~maria-captains/maria/10.0/revision/4148 (there were a couple more lines that needed fixing). And we also have the open task MDEV-6069 to remove redundant ALTERs from the script. However, there was no test in that commit, which of course is wrong. Thanks for providing one.
            elenst Elena Stepanova added a comment -

            Pushed the test into 10.0 tree as
            http://bazaar.launchpad.net/~maria-captains/maria/10.0/revision/4165

            and a separate test for 5.5 into 5.5 tree as
            http://bazaar.launchpad.net/~maria-captains/maria/5.5/revision/4166
            (the test is different because in 5.5 the logic requires manual modification of system tables).

            elenst Elena Stepanova added a comment - Pushed the test into 10.0 tree as http://bazaar.launchpad.net/~maria-captains/maria/10.0/revision/4165 and a separate test for 5.5 into 5.5 tree as http://bazaar.launchpad.net/~maria-captains/maria/5.5/revision/4166 (the test is different because in 5.5 the logic requires manual modification of system tables).

            People

              elenst Elena Stepanova
              pivanof Pavel Ivanov
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.