Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5871

support assisted discovery in oqgraph v3

Details

    Description

      OQGraph v3 tables have fixed structure, the manual says

      The CREATE statement must match the format below - any difference will result in an error.

      It would be much more user friendly to support assisted discovery and not force the user to specify the table structure at all. Then a user would only need to type, say,

      CREATE TABLE oq_graph
      		 
      ENGINE=OQGRAPH 
      data_table='oq_backing' origid='origid' destid='destid';

      Assisted discovery is easy, see federatedx.cc and sequence.cc for examples.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          View 7 older comments
          andymc73 Andrew McDonnell added a comment -

          OK, off the top of my head I'll go with 10.1 because it is effectively a new feature.
          Possibly Arjen may have a different opinion so perhaps hold off on that merge for a few days...

          As an aside, stepping back a bit I just now had a look at https://mariadb.com/kb/en/what-is-mariadb-100/ and https://mariadb.com/kb/en/plans-for-10x/ but it doesnt really explain what the "difference" is between 10.0 and 10.1

          andymc73 Andrew McDonnell added a comment - OK, off the top of my head I'll go with 10.1 because it is effectively a new feature. Possibly Arjen may have a different opinion so perhaps hold off on that merge for a few days... As an aside, stepping back a bit I just now had a look at https://mariadb.com/kb/en/what-is-mariadb-100/ and https://mariadb.com/kb/en/plans-for-10x/ but it doesnt really explain what the "difference" is between 10.0 and 10.1
          serg Sergei Golubchik added a comment -

          Okay, I'll wait.

          As for the difference — whatever features will be implemented in 10.1, they'll make the difference. Current plans are here. This search in Jira shows all tasks with the Fix-Version being 10.1, tasks with higher priority have a better chance of being implemented. As a rule of thumb you may think that all tasks with red priorities will end up and 10.1 and with green ones have a good chance of not making it. Although there are few closed (implemented) green tasks already.

          serg Sergei Golubchik added a comment - Okay, I'll wait. As for the difference — whatever features will be implemented in 10.1, they'll make the difference. Current plans are here . This search in Jira shows all tasks with the Fix-Version being 10.1, tasks with higher priority have a better chance of being implemented. As a rule of thumb you may think that all tasks with red priorities will end up and 10.1 and with green ones have a good chance of not making it. Although there are few closed (implemented) green tasks already.
          rspadim roberto spadim added a comment - - edited

          hi guys, could we do this with others engines that have 'fixed' columns? like SphinxSE
          should i open a mdev for each one that could use assisted discovery?

          rspadim roberto spadim added a comment - - edited hi guys, could we do this with others engines that have 'fixed' columns? like SphinxSE should i open a mdev for each one that could use assisted discovery?
          serg Sergei Golubchik added a comment -

          rspadim, but SphinxSE doesn't really have a fixed structure, one can choose column types and column names within certain limits.

          andymc73, shall I merge your pull request into 10.1? Meaning, it won't be in 10.0.

          serg Sergei Golubchik added a comment - rspadim , but SphinxSE doesn't really have a fixed structure, one can choose column types and column names within certain limits. andymc73 , shall I merge your pull request into 10.1? Meaning, it won't be in 10.0.
          serg Sergei Golubchik added a comment -

          Ok, 10.1 then.

          serg Sergei Golubchik added a comment - Ok, 10.1 then.

          People

            serg Sergei Golubchik
            serg Sergei Golubchik
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.