Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5317

Compound statement / anonymous blocks

Details

    Description

      Code contribution, New BSD license.

      Missing functionality: implement ATOMIC support which should create an anonymous savepoint at start of block and rollback on failure. commit if AUTOCOMMIT or remove anonymous savepoint if already in transaction.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-6603 SBR failure upon executing a prepared statement with input placeholder under anonymous block

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-6606 Server crashes in String::append on selecting sql_mode inside anonymous block

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-6609 SQL inside an anonymous block is executed with wrong SQL_MODE

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            atcurtis Antony T Curtis (Inactive) created issue -
            serg Sergei Golubchik made changes -
            Field Original Value New Value
            Fix Version/s 10.1.0 [ 12200 ]
            serg Sergei Golubchik made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            colin Colin Charles added a comment -

            Was contributed upstream also http://bugs.mysql.com/bug.php?id=70948

            colin Colin Charles added a comment - Was contributed upstream also http://bugs.mysql.com/bug.php?id=70948
            colin Colin Charles made changes -
            Labels contribution
            serg Sergei Golubchik made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ]
            dbart Daniel Bartholomew made changes -
            Priority Critical [ 2 ] Major [ 3 ]
            serg Sergei Golubchik made changes -
            Workflow defaullt [ 29815 ] MariaDB v2 [ 44009 ]
            serg Sergei Golubchik added a comment - - edited

            Okay. This is more than simply BEGIN...END, as it also includes output placeholders for prepared statements (e.g. in PREPARE "SELECT...INTO ?"). Which looks like a cool, but different feature.

            And it's unfortunately less than I expected, as it only covers (and tests) BEGIN...END (and DECLARE), but not IF and loops.

            atcurtis, what did you need this feature for, I mean, in that exactly scope?
            Do you want to work more on it, or you'd prefer if I take it as is and finalize it myself ?

            serg Sergei Golubchik added a comment - - edited Okay. This is more than simply BEGIN...END , as it also includes output placeholders for prepared statements (e.g. in PREPARE "SELECT...INTO ?" ). Which looks like a cool, but different feature. And it's unfortunately less than I expected, as it only covers (and tests) BEGIN...END (and DECLARE), but not IF and loops. atcurtis , what did you need this feature for, I mean, in that exactly scope? Do you want to work more on it, or you'd prefer if I take it as is and finalize it myself ?
            serg Sergei Golubchik made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            serg Sergei Golubchik made changes -
            Status In Progress [ 3 ] Stalled [ 10000 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.1 [ 16100 ]
            Fix Version/s 10.1.0 [ 12200 ]
            serg Sergei Golubchik added a comment -

            Ah, and there's also SET ? = expr syntax.
            atcurtis — why did you do that? Any use cases?

            serg Sergei Golubchik added a comment - Ah, and there's also SET ? = expr syntax. atcurtis — why did you do that? Any use cases?
            serg Sergei Golubchik made changes -
            Status Stalled [ 10000 ] In Progress [ 3 ]
            serg Sergei Golubchik added a comment -

            I've now pushed a — significantly reworked — patch to github. Without SET ? = expr syntax, but with SELECT ... INTO ?. Without BEGIN ATOMIC (it wasn't atomic in the contributed patch either, in mine it is not accepted at all). And with support for IF, CASE, LOOP, REPEAT, WHILE.

            serg Sergei Golubchik added a comment - I've now pushed a — significantly reworked — patch to github. Without SET ? = expr syntax, but with SELECT ... INTO ? . Without BEGIN ATOMIC (it wasn't atomic in the contributed patch either, in mine it is not accepted at all). And with support for IF , CASE , LOOP , REPEAT , WHILE .
            serg Sergei Golubchik added a comment -

            elenst, could you please do some testing of this feature?

            serg Sergei Golubchik added a comment - elenst , could you please do some testing of this feature?
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Elena Stepanova [ elenst ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            elenst Elena Stepanova made changes -
            elenst Elena Stepanova made changes -
            elenst Elena Stepanova made changes -
            elenst Elena Stepanova made changes -
            elenst Elena Stepanova made changes -
            elenst Elena Stepanova added a comment -

            Assorted notes

            New status variable: Com_compound_sql

            From http://dev.mysql.com/doc/refman/5.6/en/sql-syntax-compound-statements.html

            • RETURN does not work (expectedly)
            • (for outermost blocks) labels, ITERATE, LEAVE do not work
            elenst Elena Stepanova added a comment - Assorted notes New status variable: Com_compound_sql From http://dev.mysql.com/doc/refman/5.6/en/sql-syntax-compound-statements.html RETURN does not work (expectedly) (for outermost blocks) labels, ITERATE , LEAVE do not work
            elenst Elena Stepanova added a comment -

            Ran some manual and automated tests, haven't got anything except for the issues listed in "Issue Links" section. Please push, and I will include new functionality in my general auto tests.

            elenst Elena Stepanova added a comment - Ran some manual and automated tests, haven't got anything except for the issues listed in "Issue Links" section. Please push, and I will include new functionality in my general auto tests.
            elenst Elena Stepanova made changes -
            Assignee Elena Stepanova [ elenst ] Sergei Golubchik [ serg ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            sanja Oleksandr Byelkin made changes -
            Assignee Sergei Golubchik [ serg ] Oleksandr Byelkin [ sanja ]
            sanja Oleksandr Byelkin made changes -
            Status Stalled [ 10000 ] In Progress [ 3 ]
            sanja Oleksandr Byelkin made changes -
            Assignee Oleksandr Byelkin [ sanja ] Sergei Golubchik [ serg ]
            sanja Oleksandr Byelkin added a comment -

            OK to push

            sanja Oleksandr Byelkin added a comment - OK to push
            serg Sergei Golubchik made changes -
            Status In Progress [ 3 ] Stalled [ 10000 ]
            serg Sergei Golubchik made changes -
            Component/s OTHER [ 10125 ]
            Fix Version/s 10.1.1 [ 16801 ]
            Fix Version/s 10.1 [ 16100 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Workflow MariaDB v2 [ 44009 ] MariaDB v3 [ 65069 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 65069 ] MariaDB v4 [ 132226 ]

            People

              serg Sergei Golubchik
              atcurtis Antony T Curtis (Inactive)
              Votes:
              3 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.