Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4646

No mysqld-debug or debuginfo in MariaDB-Server RPM

Details

    • 10.1.22

    Description

      Oracle MySQL-Server RPMs include a mysqld-debug binary, but MariaDB-Server RPMs do not. MariaDB should either include mysqld-debug in the MariaDB-Server RPM or should offer it in a separate RPM for situations when it is necessary to use the debug-enabled server.

      Attachments

        Issue Links

          Activity

            danblack Daniel Black added a comment -

            I think it will be good enough for mariadb package distribution to have debug symbol packages that can map to a source. The main reason for pushing this was so existing core dumps can be analysed without users to build debug versions or attempt to reproduce the bug. Developers can also use debug packages to analyse user core dumps. Fedora is still crafting its own spec file https://src.fedoraproject.org/cgit/rpms/mariadb.git/tree/ (and I'm not sure why _ maybe the rest of their build infrastrure depends on it)

            danblack Daniel Black added a comment - I think it will be good enough for mariadb package distribution to have debug symbol packages that can map to a source. The main reason for pushing this was so existing core dumps can be analysed without users to build debug versions or attempt to reproduce the bug. Developers can also use debug packages to analyse user core dumps. Fedora is still crafting its own spec file https://src.fedoraproject.org/cgit/rpms/mariadb.git/tree/ (and I'm not sure why _ maybe the rest of their build infrastrure depends on it)
            serg Sergei Golubchik added a comment - - edited

            danblack, I fully agree with that. But if we build with non-standard manually installed cmake, we will get builds that users won't be able to reproduce (on a stock distro installation). That might still be fine. But then there's a good chance we break the build for older cmake versions and won't even notice it.

            Perhaps we should switch to using manually installed new cmake almost everywhere, but keep the oldest supported cmake at least one one builder, just to make sure it still works...

            Another thought — this RPM-DEFAULT patch. I've pushed it under assumption that it'll work for all new distributions, not for old one. If we switch to a new cmake on old distros, we'll have to document that "mariadb rpm is named XXX for versions 5.5.x and below, 10.0.y and below, 10.1.z and below, and it's named YYY for newer 5.5, 10.0, 10.1 versions". Of course, we can have this in the manual, but I think we'd better not to.

            serg Sergei Golubchik added a comment - - edited danblack , I fully agree with that. But if we build with non-standard manually installed cmake, we will get builds that users won't be able to reproduce (on a stock distro installation). That might still be fine. But then there's a good chance we break the build for older cmake versions and won't even notice it. Perhaps we should switch to using manually installed new cmake almost everywhere, but keep the oldest supported cmake at least one one builder, just to make sure it still works... Another thought — this RPM-DEFAULT patch. I've pushed it under assumption that it'll work for all new distributions, not for old one. If we switch to a new cmake on old distros, we'll have to document that "mariadb rpm is named XXX for versions 5.5.x and below, 10.0.y and below, 10.1.z and below, and it's named YYY for newer 5.5, 10.0, 10.1 versions". Of course, we can have this in the manual, but I think we'd better not to.
            danblack Daniel Black added a comment -

            Fedora-25 has cmake-3.8 up from 3.6 in FC24 so its gradually changing (as is openSUSE).

            An distro cmake on one builder sounds very sane.

            The RPM-DEFAULT patch defers the package name to the rpmbuilder in the distribution. I don't imagine any distribution has that broken.

            Do you think cmake/cpack_rpm.cmake CPACK_RPM_XXX_PACKAGE_OBSOLETES needs to refer to the old mariadb rpm name?

            danblack Daniel Black added a comment - Fedora-25 has cmake-3.8 up from 3.6 in FC24 so its gradually changing (as is openSUSE ). An distro cmake on one builder sounds very sane. The RPM-DEFAULT patch defers the package name to the rpmbuilder in the distribution. I don't imagine any distribution has that broken. Do you think cmake/cpack_rpm.cmake CPACK_RPM_XXX_PACKAGE_OBSOLETES needs to refer to the old mariadb rpm name?

            No, I don't. I think the rpm package name was always MariaDB-server, MariaDB-client, etc. This didn't change. RPM-DEFAULT only changed file names, but MariaDB-server still means what it used to mean.

            serg Sergei Golubchik added a comment - No, I don't. I think the rpm package name was always MariaDB-server, MariaDB-client, etc. This didn't change. RPM-DEFAULT only changed file names, but MariaDB-server still means what it used to mean.
            danblack Daniel Black added a comment -

            Good to know RPM names/filenames are distinguished.

            I finally read your comments and MDEV-11258 correctly. You're saying a followup task is needed to use cmake-3.7+ on most builders (perhaps MDEV-12508). I agree.

            On rpm documentation - seems that kb pages mentioning RPM could just mention the two forms of filename https://mariadb.com/kb/en/mariadb/about-the-mariadb-rpm-files/. Or like mentioned on https://mariadb.com/kb/en/mariadb/installing-mariadb-with-the-rpm-tool/ "look similar to ...". (or do a major cull of RPM documentation to mainly refer to yum repo based installs).

            danblack Daniel Black added a comment - Good to know RPM names/filenames are distinguished. I finally read your comments and MDEV-11258 correctly. You're saying a followup task is needed to use cmake-3.7+ on most builders (perhaps MDEV-12508 ). I agree. On rpm documentation - seems that kb pages mentioning RPM could just mention the two forms of filename https://mariadb.com/kb/en/mariadb/about-the-mariadb-rpm-files/ . Or like mentioned on https://mariadb.com/kb/en/mariadb/installing-mariadb-with-the-rpm-tool/ "look similar to ...". (or do a major cull of RPM documentation to mainly refer to yum repo based installs).

            People

              serg Sergei Golubchik
              kolbe Kolbe Kegel (Inactive)
              Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.