Type:
Task
Priority:
Major
Resolution:
Fixed
Component/s:
None
Please consider including the attached patch into MariaDB.
It cleans up the code in sql/sql_acl.cc so that it usess enum values to index different ACL tables instead of hard-coded numbers as indexes. This makes the code more understandable for the reader and less prone to errors during merges between independent changes.
{"report":{"fcp":3003.0999999046326,"ttfb":279.5,"pageVisibility":"visible","entityId":24138,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"f8989ed2-970c-4a0e-85c5-01f3feb8af0b","navigationType":0,"readyForUser":2846,"redirectCount":0,"resourceLoadedEnd":3449.899999856949,"resourceLoadedStart":287.09999990463257,"resourceTiming":[{"duration":100.20000004768372,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":287.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":287.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":387.2999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":100.10000014305115,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":287.39999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":287.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":387.5,"responseStart":0,"secureConnectionStart":0},{"duration":1919.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":287.59999990463257,"connectEnd":287.59999990463257,"connectStart":287.59999990463257,"domainLookupEnd":287.59999990463257,"domainLookupStart":287.59999990463257,"fetchStart":287.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":391.69999980926514,"responseEnd":2207.399999856949,"responseStart":1438.5,"secureConnectionStart":287.59999990463257},{"duration":2102.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":287.7999999523163,"connectEnd":287.7999999523163,"connectStart":287.7999999523163,"domainLookupEnd":287.7999999523163,"domainLookupStart":287.7999999523163,"fetchStart":287.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":394.39999985694885,"responseEnd":2390,"responseStart":1117.1999998092651,"secureConnectionStart":287.7999999523163},{"duration":1150.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":287.89999985694885,"connectEnd":287.89999985694885,"connectStart":287.89999985694885,"domainLookupEnd":287.89999985694885,"domainLookupStart":287.89999985694885,"fetchStart":287.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":394.89999985694885,"responseEnd":1438.3999998569489,"responseStart":1177,"secureConnectionStart":287.89999985694885},{"duration":888.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":288.19999980926514,"connectEnd":288.19999980926514,"connectStart":288.19999980926514,"domainLookupEnd":288.19999980926514,"domainLookupStart":288.19999980926514,"fetchStart":288.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":395,"responseEnd":1176.8999998569489,"responseStart":1175.2999999523163,"secureConnectionStart":288.19999980926514},{"duration":1377.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":288.39999985694885,"connectEnd":288.39999985694885,"connectStart":288.39999985694885,"domainLookupEnd":288.39999985694885,"domainLookupStart":288.39999985694885,"fetchStart":288.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":395.2999999523163,"responseEnd":1665.6999998092651,"responseStart":1557.6999998092651,"secureConnectionStart":288.39999985694885},{"duration":102.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":288.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":288.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":391,"responseStart":0,"secureConnectionStart":0},{"duration":1555.8000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":288.69999980926514,"connectEnd":288.69999980926514,"connectStart":288.69999980926514,"domainLookupEnd":288.69999980926514,"domainLookupStart":288.69999980926514,"fetchStart":288.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":395.39999985694885,"responseEnd":1844.5,"responseStart":1665.8999998569489,"secureConnectionStart":288.69999980926514},{"duration":102.29999995231628,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":288.89999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":288.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":391.19999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":1268.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":289,"connectEnd":289,"connectStart":289,"domainLookupEnd":289,"domainLookupStart":289,"fetchStart":289,"redirectEnd":0,"redirectStart":0,"requestStart":395.59999990463257,"responseEnd":1557.5,"responseStart":1449.3999998569489,"secureConnectionStart":289},{"duration":3146.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":298.89999985694885,"connectEnd":298.89999985694885,"connectStart":298.89999985694885,"domainLookupEnd":298.89999985694885,"domainLookupStart":298.89999985694885,"fetchStart":298.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":659,"responseEnd":3445.199999809265,"responseStart":3288.0999999046326,"secureConnectionStart":298.89999985694885},{"duration":3150.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":298.89999985694885,"connectEnd":298.89999985694885,"connectStart":298.89999985694885,"domainLookupEnd":298.89999985694885,"domainLookupStart":298.89999985694885,"fetchStart":298.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":842.2999999523163,"responseEnd":3449.0999999046326,"responseStart":3440.5999999046326,"secureConnectionStart":298.89999985694885},{"duration":89.79999995231628,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":2400.899999856949,"connectEnd":2400.899999856949,"connectStart":2400.899999856949,"domainLookupEnd":2400.899999856949,"domainLookupStart":2400.899999856949,"fetchStart":2400.899999856949,"redirectEnd":0,"redirectStart":0,"requestStart":2420.699999809265,"responseEnd":2490.699999809265,"responseStart":2489.399999856949,"secureConnectionStart":2400.899999856949},{"duration":196.40000009536743,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":2647.699999809265,"connectEnd":2647.699999809265,"connectStart":2647.699999809265,"domainLookupEnd":2647.699999809265,"domainLookupStart":2647.699999809265,"fetchStart":2647.699999809265,"redirectEnd":0,"redirectStart":0,"requestStart":2652.199999809265,"responseEnd":2844.0999999046326,"responseStart":2708.399999856949,"secureConnectionStart":2647.699999809265},{"duration":237.79999995231628,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":2768,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":2768,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":3005.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":451.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":2998.2999999523163,"connectEnd":2998.2999999523163,"connectStart":2998.2999999523163,"domainLookupEnd":2998.2999999523163,"domainLookupStart":2998.2999999523163,"fetchStart":2998.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":3027.5999999046326,"responseEnd":3449.899999856949,"responseStart":3447.399999856949,"secureConnectionStart":2998.2999999523163}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":125,"responseStart":279,"responseEnd":297,"domLoading":284,"domInteractive":3485,"domContentLoadedEventStart":3485,"domContentLoadedEventEnd":3536,"domComplete":3896,"loadEventStart":3896,"loadEventEnd":3899,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":3473.2999999523163},{"name":"bigPipe.sidebar-id.end","time":3474.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.start","time":3474.199999809265},{"name":"bigPipe.activity-panel-pipe-id.end","time":3476.699999809265},{"name":"activityTabFullyLoaded","time":3545.2999999523163}],"measures":[],"correlationId":"775ab03b41de1","effectiveType":"4g","downlink":9.8,"rtt":0,"serverDuration":93,"dbReadsTimeInMs":9,"dbConnsTimeInMs":17,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}