Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4549

[PATCH] Clean up code working with ACL tables

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.1.0
    • None
    • None

    Description

      Please consider including the attached patch into MariaDB.
      It cleans up the code in sql/sql_acl.cc so that it usess enum values to index different ACL tables instead of hard-coded numbers as indexes. This makes the code more understandable for the reader and less prone to errors during merges between independent changes.

      Attachments

        1. acl.diff
          46 kB
        2. patch.txt
          33 kB

        Activity

          Ascending order - Click to sort in descending order
          serg Sergei Golubchik added a comment -

          svoj, could you please review this cleanup patch? Thanks.

          serg Sergei Golubchik added a comment - svoj , could you please review this cleanup patch? Thanks.
          svoj Sergey Vojtovich added a comment -

          Ok to push.

          svoj Sergey Vojtovich added a comment - Ok to push.

          People

            serg Sergei Golubchik
            pivanof Pavel Ivanov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.