Type:
Task
Priority:
Major
Resolution:
Fixed
Component/s:
None
Please consider including the attached patch into MariaDB.
It cleans up the code in sql/sql_acl.cc so that it usess enum values to index different ACL tables instead of hard-coded numbers as indexes. This makes the code more understandable for the reader and less prone to errors during merges between independent changes.
{"report":{"fcp":1312.6999998092651,"ttfb":324.19999980926514,"pageVisibility":"visible","entityId":24138,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"fd9ede1e-122d-4657-b303-a190d50f6fc5","navigationType":0,"readyForUser":1388.5,"redirectCount":0,"resourceLoadedEnd":1598.1999998092651,"resourceLoadedStart":330,"resourceTiming":[{"duration":397.8999996185303,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":330,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":330,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":727.8999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":398,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":330.2999997138977,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":330.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":728.2999997138977,"responseStart":0,"secureConnectionStart":0},{"duration":457.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":330.5,"connectEnd":330.5,"connectStart":330.5,"domainLookupEnd":330.5,"domainLookupStart":330.5,"fetchStart":330.5,"redirectEnd":0,"redirectStart":0,"requestStart":330.5,"responseEnd":788,"responseStart":787.8999996185303,"secureConnectionStart":330.5},{"duration":548.8000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":330.69999980926514,"connectEnd":330.69999980926514,"connectStart":330.69999980926514,"domainLookupEnd":330.69999980926514,"domainLookupStart":330.69999980926514,"fetchStart":330.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":330.69999980926514,"responseEnd":879.5,"responseStart":879.5,"secureConnectionStart":330.69999980926514},{"duration":552.6000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":330.8999996185303,"connectEnd":330.8999996185303,"connectStart":330.8999996185303,"domainLookupEnd":330.8999996185303,"domainLookupStart":330.8999996185303,"fetchStart":330.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":330.8999996185303,"responseEnd":883.5,"responseStart":883.5,"secureConnectionStart":330.8999996185303},{"duration":552.6999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":331.19999980926514,"connectEnd":331.19999980926514,"connectStart":331.19999980926514,"domainLookupEnd":331.19999980926514,"domainLookupStart":331.19999980926514,"fetchStart":331.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":331.19999980926514,"responseEnd":883.8999996185303,"responseStart":883.8999996185303,"secureConnectionStart":331.19999980926514},{"duration":553,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":331.2999997138977,"connectEnd":331.2999997138977,"connectStart":331.2999997138977,"domainLookupEnd":331.2999997138977,"domainLookupStart":331.2999997138977,"fetchStart":331.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":331.2999997138977,"responseEnd":884.2999997138977,"responseStart":884.2999997138977,"secureConnectionStart":331.2999997138977},{"duration":602.6999998092651,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":331.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":331.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":934.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":553.0999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":331.59999990463257,"connectEnd":331.59999990463257,"connectStart":331.59999990463257,"domainLookupEnd":331.59999990463257,"domainLookupStart":331.59999990463257,"fetchStart":331.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":331.59999990463257,"responseEnd":884.6999998092651,"responseStart":884.6999998092651,"secureConnectionStart":331.59999990463257},{"duration":602.6999998092651,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":331.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":331.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":934.3999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":553.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":331.8999996185303,"connectEnd":331.8999996185303,"connectStart":331.8999996185303,"domainLookupEnd":331.8999996185303,"domainLookupStart":331.8999996185303,"fetchStart":331.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":331.8999996185303,"responseEnd":885.2999997138977,"responseStart":885.2999997138977,"secureConnectionStart":331.8999996185303},{"duration":707.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":332.69999980926514,"connectEnd":332.69999980926514,"connectStart":332.69999980926514,"domainLookupEnd":332.69999980926514,"domainLookupStart":332.69999980926514,"fetchStart":332.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":332.69999980926514,"responseEnd":1040.1999998092651,"responseStart":1040.0999999046326,"secureConnectionStart":332.69999980926514},{"duration":1264.5999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":332.69999980926514,"connectEnd":332.69999980926514,"connectStart":332.69999980926514,"domainLookupEnd":332.69999980926514,"domainLookupStart":332.69999980926514,"fetchStart":332.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":332.69999980926514,"responseEnd":1597.2999997138977,"responseStart":1597.2999997138977,"secureConnectionStart":332.69999980926514},{"duration":94.40000009536743,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":946.1999998092651,"connectEnd":946.1999998092651,"connectStart":946.1999998092651,"domainLookupEnd":946.1999998092651,"domainLookupStart":946.1999998092651,"fetchStart":946.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":946.1999998092651,"responseEnd":1040.5999999046326,"responseStart":1040.5999999046326,"secureConnectionStart":946.1999998092651},{"duration":389.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1208.6999998092651,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1208.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1598.1999998092651,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":183,"responseStart":324,"responseEnd":328,"domLoading":328,"domInteractive":1618,"domContentLoadedEventStart":1618,"domContentLoadedEventEnd":1657,"domComplete":1864,"loadEventStart":1864,"loadEventEnd":1865,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1601.6999998092651},{"name":"bigPipe.sidebar-id.end","time":1602.5},{"name":"bigPipe.activity-panel-pipe-id.start","time":1602.6999998092651},{"name":"bigPipe.activity-panel-pipe-id.end","time":1603.6999998092651},{"name":"activityTabFullyLoaded","time":1669.7999997138977}],"measures":[],"correlationId":"eace0735d283c3","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":89,"dbReadsTimeInMs":9,"dbConnsTimeInMs":17,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
svoj, could you please review this cleanup patch? Thanks.