Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4549

[PATCH] Clean up code working with ACL tables

    XMLWordPrintable

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.1.0
    • None
    • None

    Description

      Please consider including the attached patch into MariaDB.
      It cleans up the code in sql/sql_acl.cc so that it usess enum values to index different ACL tables instead of hard-coded numbers as indexes. This makes the code more understandable for the reader and less prone to errors during merges between independent changes.

      Attachments

        1. patch.txt
          33 kB
        2. acl.diff
          46 kB

        Activity

          People

            serg Sergei Golubchik
            pivanof Pavel Ivanov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 3h
                3h
                Remaining:
                Time Spent - 0.25d Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - 0.25d Remaining Estimate - 1h
                0.25d

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.