Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4549

[PATCH] Clean up code working with ACL tables

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.1.0
    • None
    • None

    Description

      Please consider including the attached patch into MariaDB.
      It cleans up the code in sql/sql_acl.cc so that it usess enum values to index different ACL tables instead of hard-coded numbers as indexes. This makes the code more understandable for the reader and less prone to errors during merges between independent changes.

      Attachments

        1. acl.diff
          46 kB
        2. patch.txt
          33 kB

        Activity

          Ascending order - Click to sort in descending order
          pivanof Pavel Ivanov created issue -
          serg Sergei Golubchik made changes -
          Field Original Value New Value
          Fix Version/s 10.0.3 [ 12900 ]
          serg Sergei Golubchik made changes -
          Issue Type Bug [ 1 ] Task [ 3 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 10.0.4 [ 13101 ]
          Fix Version/s 10.0.3 [ 12900 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 10.0.5 [ 13201 ]
          Fix Version/s 10.0.4 [ 13101 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 10.0.6 [ 13202 ]
          Fix Version/s 10.0.5 [ 13201 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 10.0.7 [ 14100 ]
          Fix Version/s 10.0.6 [ 13202 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 10.0.8 [ 14200 ]
          Fix Version/s 10.0.7 [ 14100 ]
          serg Sergei Golubchik made changes -
          Priority Minor [ 4 ] Major [ 3 ]
          serg Sergei Golubchik made changes -
          Assignee Sergey Vojtovich [ svoj ]
          serg Sergei Golubchik made changes -
          Assignee Sergey Vojtovich [ svoj ] Sergei Golubchik [ serg ]
          serg Sergei Golubchik made changes -
          Priority Major [ 3 ] Minor [ 4 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 10.0.9 [ 14400 ]
          Fix Version/s 10.0.8 [ 14200 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 10.1.0 [ 12200 ]
          Fix Version/s 10.0.9 [ 14400 ]
          serg Sergei Golubchik made changes -
          Attachment acl.diff [ 26900 ]
          serg Sergei Golubchik made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          serg Sergei Golubchik made changes -
          Status In Progress [ 3 ] Stalled [ 10000 ]
          serg Sergei Golubchik made changes -
          Priority Minor [ 4 ] Major [ 3 ]
          serg Sergei Golubchik made changes -
          Workflow defaullt [ 27438 ] MariaDB v2 [ 42838 ]
          serg Sergei Golubchik made changes -
          Status Stalled [ 10000 ] In Progress [ 3 ]
          serg Sergei Golubchik added a comment -

          svoj, could you please review this cleanup patch? Thanks.

          serg Sergei Golubchik added a comment - svoj , could you please review this cleanup patch? Thanks.
          serg Sergei Golubchik made changes -
          Assignee Sergei Golubchik [ serg ] Sergey Vojtovich [ svoj ]
          Status In Progress [ 3 ] In Review [ 10002 ]
          serg Sergei Golubchik made changes -
          Comment [ I'll attach my (incomplete) patch — acl.diff. It should go in 10.1 ]
          serg Sergei Golubchik made changes -
          Attachment acl.diff [ 26900 ]
          serg Sergei Golubchik made changes -
          Attachment acl.diff [ 31013 ]
          serg Sergei Golubchik made changes -
          Attachment acl.diff [ 31013 ]
          serg Sergei Golubchik made changes -
          Attachment acl.diff [ 31014 ]
          svoj Sergey Vojtovich added a comment -

          Ok to push.

          svoj Sergey Vojtovich added a comment - Ok to push.
          svoj Sergey Vojtovich made changes -
          Assignee Sergey Vojtovich [ svoj ] Sergei Golubchik [ serg ]
          Status In Review [ 10002 ] Stalled [ 10000 ]
          serg Sergei Golubchik made changes -
          Status Stalled [ 10000 ] In Progress [ 3 ]
          serg Sergei Golubchik made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Closed [ 6 ]
          ratzpo Rasmus Johansson (Inactive) made changes -
          Workflow MariaDB v2 [ 42838 ] MariaDB v3 [ 61729 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 61729 ] MariaDB v4 [ 132128 ]

          People

            serg Sergei Golubchik
            pivanof Pavel Ivanov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.