Type:
Task
Priority:
Major
Resolution:
Fixed
Component/s:
None
Please consider including the attached patch into MariaDB.
It cleans up the code in sql/sql_acl.cc so that it usess enum values to index different ACL tables instead of hard-coded numbers as indexes. This makes the code more understandable for the reader and less prone to errors during merges between independent changes.
{"report":{"fcp":750.0999999046326,"ttfb":166.5,"pageVisibility":"visible","entityId":24138,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"ee44242a-57c0-4770-a7fb-3122ede004d1","navigationType":0,"readyForUser":820.1999998092651,"redirectCount":0,"resourceLoadedEnd":773.7999999523163,"resourceLoadedStart":171.89999985694885,"resourceTiming":[{"duration":7.400000095367432,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":171.89999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":171.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":179.29999995231628,"responseStart":0,"secureConnectionStart":0},{"duration":7.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":172.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":172.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":179.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":61.799999952316284,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":172.29999995231628,"connectEnd":172.29999995231628,"connectStart":172.29999995231628,"domainLookupEnd":172.29999995231628,"domainLookupStart":172.29999995231628,"fetchStart":172.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":172.29999995231628,"responseEnd":234.09999990463257,"responseStart":234.09999990463257,"secureConnectionStart":172.29999995231628},{"duration":148.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":172.5,"connectEnd":172.5,"connectStart":172.5,"domainLookupEnd":172.5,"domainLookupStart":172.5,"fetchStart":172.5,"redirectEnd":0,"redirectStart":0,"requestStart":172.5,"responseEnd":321.2999999523163,"responseStart":321.2999999523163,"secureConnectionStart":172.5},{"duration":152.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":172.69999980926514,"connectEnd":172.69999980926514,"connectStart":172.69999980926514,"domainLookupEnd":172.69999980926514,"domainLookupStart":172.69999980926514,"fetchStart":172.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":172.69999980926514,"responseEnd":325.19999980926514,"responseStart":325.19999980926514,"secureConnectionStart":172.69999980926514},{"duration":152.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":172.89999985694885,"connectEnd":172.89999985694885,"connectStart":172.89999985694885,"domainLookupEnd":172.89999985694885,"domainLookupStart":172.89999985694885,"fetchStart":172.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":172.89999985694885,"responseEnd":325.69999980926514,"responseStart":325.69999980926514,"secureConnectionStart":172.89999985694885},{"duration":152.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":173.09999990463257,"connectEnd":173.09999990463257,"connectStart":173.09999990463257,"domainLookupEnd":173.09999990463257,"domainLookupStart":173.09999990463257,"fetchStart":173.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":173.09999990463257,"responseEnd":326,"responseStart":326,"secureConnectionStart":173.09999990463257},{"duration":204.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":173.29999995231628,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":173.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":377.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":153.10000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":173.39999985694885,"connectEnd":173.39999985694885,"connectStart":173.39999985694885,"domainLookupEnd":173.39999985694885,"domainLookupStart":173.39999985694885,"fetchStart":173.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":173.39999985694885,"responseEnd":326.5,"responseStart":326.5,"secureConnectionStart":173.39999985694885},{"duration":204.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":173.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":173.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":378.09999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":153.20000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":173.79999995231628,"connectEnd":173.79999995231628,"connectStart":173.79999995231628,"domainLookupEnd":173.79999995231628,"domainLookupStart":173.79999995231628,"fetchStart":173.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":173.79999995231628,"responseEnd":327,"responseStart":327,"secureConnectionStart":173.79999995231628},{"duration":273.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":174.69999980926514,"connectEnd":174.69999980926514,"connectStart":174.69999980926514,"domainLookupEnd":174.69999980926514,"domainLookupStart":174.69999980926514,"fetchStart":174.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":174.69999980926514,"responseEnd":448.39999985694885,"responseStart":448.39999985694885,"secureConnectionStart":174.69999980926514},{"duration":320.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":174.69999980926514,"connectEnd":174.69999980926514,"connectStart":174.69999980926514,"domainLookupEnd":174.69999980926514,"domainLookupStart":174.69999980926514,"fetchStart":174.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":174.69999980926514,"responseEnd":494.89999985694885,"responseStart":494.89999985694885,"secureConnectionStart":174.69999980926514},{"duration":59.89999985694885,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":389.5,"connectEnd":389.5,"connectStart":389.5,"domainLookupEnd":389.5,"domainLookupStart":389.5,"fetchStart":389.5,"redirectEnd":0,"redirectStart":0,"requestStart":389.5,"responseEnd":449.39999985694885,"responseStart":449.39999985694885,"secureConnectionStart":389.5},{"duration":106.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":667,"connectEnd":667,"connectStart":667,"domainLookupEnd":667,"domainLookupStart":667,"fetchStart":667,"redirectEnd":0,"redirectStart":0,"requestStart":667,"responseEnd":773.7999999523163,"responseStart":773.7999999523163,"secureConnectionStart":667},{"duration":104.40000009536743,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":744.0999999046326,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":744.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":848.5,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":7,"responseStart":167,"responseEnd":169,"domLoading":170,"domInteractive":873,"domContentLoadedEventStart":873,"domContentLoadedEventEnd":916,"domComplete":1009,"loadEventStart":1009,"loadEventEnd":1009,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":850.3999998569489},{"name":"bigPipe.sidebar-id.end","time":851.1999998092651},{"name":"bigPipe.activity-panel-pipe-id.start","time":851.3999998569489},{"name":"bigPipe.activity-panel-pipe-id.end","time":852.5},{"name":"activityTabFullyLoaded","time":933.0999999046326}],"measures":[],"correlationId":"5703c8132467e8","effectiveType":"4g","downlink":9.5,"rtt":0,"serverDuration":95,"dbReadsTimeInMs":8,"dbConnsTimeInMs":17,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
svoj, could you please review this cleanup patch? Thanks.