Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-41027

Missing space: Failed to load table…foreign key withTABLE_NAME

    XMLWordPrintable

Details

    • Unexpected results

    Description

      In a hardcoded error message in innobase_update_foreign_cache(), there is a missing space after the word "with":

      			ib::error()
      				<< "Failed to load table "
      				<< table_name_t(const_cast<char*>(f))
      				<< " which has a foreign key constraint with"
      				<< user_table->name;
      

      It looks like this message is suppressed in the test innodb.alter_foreign_crash, but we fail to check for the exact message, so the incorrect formatting does not appear in any .result file.

      While we are changing this, I would replace the call with sql_print_error(). It would seem to be easiest to fix this starting with the 11.8 release series, which is the first one to include MDEV-21978. Use the format string "%.*sQ.%sQ" for pretty-printing table names. Please test with table names that contain a non-alphanumeric character, such as $.

      This typo was originally noticed by monty in MDEV-25292.

      Attachments

        Issue Links

          Activity

            People

              tafzeel Mohammad Tafzeel Shams
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - 0d
                  0d
                  Remaining:
                  Time Spent - 0.5h Remaining Estimate - 3.5d
                  3.5d
                  Logged:
                  Time Spent - 0.5h Remaining Estimate - 3.5d
                  0.5h

                  Git Integration

                    Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.