Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-38408

WITH_DBUG_TRACE=OFF doesn't disable DBUG_DUMP or DBUG_LOG

    XMLWordPrintable

Details

    • Not for Release Notes
    • The regression test suite could occasionally fail due to test case timeouts due to some DBUG tracing code that is unnecessarily being included and executed in CMAKE_BUILD_TYPE=Debug builds.

    Description

      Even after it was improved in MDEV-29613, the setting WITH_DBUG_TRACE=OFF does not disable DBUG_LOG or DBUG_DUMP.

      I suspect that this additional code bloat could cause some test case timeouts on debug-instrumented builds. I became aware of this when diagnosing MDEV-38391. To reproduce this, run the following:

      mysql-test/mtr innodb.import_hidden_fts_debug
      		 
      cat mysql-test/var/log/mysqld.1.err

      On 11.4, even after my fix, this would produce some print_where() output, but I think that we can live with that. The culprit for that output should be that the test fails to work around MDEV-21361.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21361 +d,-d may break consistent state of DEBUG_DBUG

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. MDEV-29613 Improve WITH_DBUG_TRACE=OFF

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. MDEV-33073 always green buildbot

          • Major - Major loss of function.
          • Stalled

          Bug - A problem which impairs or prevents the functions of the product. MDEV-38391 Memory leak in innodb.import_hidden_fts_debug

          • Critical - Crashes, loss of data, severe memory leak.
          • Confirmed

          Activity

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Marko Mäkelä Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.