Details

    Description

      The initial implementation of the CMake parameter WITH_DBUG_TRACE allows some of the DBUG trace output to be disabled while leaving other important DBUG functionality intact - things like DBUG_ASSERT, DBUG_EXECUTE_IF.

      This patch however was incomplete - it disabled DBUG_ENTER and DBUG_RETURN however left DBUG_PRINT in place.

      It turns out that only a small number of InnoDB redo log related tests were making use of DEBUG_DBUG='+d,ib_log' to check that some log records were written or parsed. We can live very well without those checks.

      Conditional branches are bad for tools like the rr debugger. Even if all DBUG_PRINT statements are normally disabled in test runs, the conditional branches would create unnecessary (and useless) opportunity of context switches in rr. I have witnessed a case where a test that would take more than 2 hours to run would finish in a few seconds when the server was compiled with cmake -DPLUGIN_PERFSCHEMA=NO -DWITH_DBUG_TRACE=OFF -DWITH_SAFEMALLOC=OFF.

      Attachments

        Issue Links

          Activity

            Transition Time In Source Status Execution Times
            Marko Mäkelä made transition -
            Open In Progress
            1h 40m 1
            Marko Mäkelä made transition -
            In Progress In Review
            10s 1
            Vladislav Vaintroub made transition -
            In Review Stalled
            36m 47s 1
            Marko Mäkelä made transition -
            Stalled Closed
            1h 36m 1

            People

              marko Marko Mäkelä
              wlad Vladislav Vaintroub
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.