Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-37810

Introduce combinations of gbh and usual handlers to spider tests

    XMLWordPrintable

Details

    Description

      Spider has two routes of execution: usual handler and group by handler (gbh). The usual handler uses common handler methods, whereas the gbh takes over the query execution after optimization and executes the query directly on the data node, with the gbh being the default unless spider_disable_group_by_handler is set to 1 (10.11+) or a gbh cannot be created due to various limitations. In MDEV-27260 we will add select handler which is an earlier direct execution to 10.11, and in the same task to ensure test coverage we will also add combinations to all spider tests:

      combinations

      [group_by_handler]
      loose_spider_disable_select_handler=1
      loose_spider_disable_group_by_handler=0
       
      # [usual_handler]
      # loose_spider_disable_select_handler=1
      # loose_spider_disable_group_by_handler=1
       
      [select_handler]
      loose_spider_disable_select_handler=0
      loose_spider_disable_group_by_handler=0
      

      This task is basically uncommenting the usual_handler section in the above, with or without the select_handler section. It will improve test coverage and uncover bugs like MDEV-36325. It will also mean that we can automatically disable view protocol for result mismatch failures caused by different code paths, as all code paths will be covered in combinations.

      Attachments

        Issue Links

          Activity

            People

              ycp Yuchen Pei
              ycp Yuchen Pei
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.