Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-36675

Optimizer hints parser catches irrelevant `thd->is_error()` set by multi-RENAME TABLE

Details

    • Bug
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Fixed
    • None
    • 12.0.1
    • Optimizer
    • None

    Description

      This task is split from MDEV-36484 and proposes an alternative solution to the same problem. The test is the same:

      CREATE TABLE t1 (a INT);
      		 
      CREATE TRIGGER t1 AFTER INSERT ON t1 FOR EACH ROW INSERT INTO t1 VALUES (0);
      		 
      RENAME TABLE t1 TO c,v2 TO t;

      The description of the problem can be found in MDEV-36484 as well. In short: optimizer hints parser is sensitive to `thd->is_error()` set elsewhere. That behavior must be changed so it is only catches its own fatal errors

      Attachments

        Issue Links

          is caused by

          New Feature - A new feature of the product, which has yet to be developed. MDEV-34870 Implement join order hints

          • Critical - Crashes, loss of data, severe memory leak.
          • In Testing
          split from

          Bug - A problem which impairs or prevents the functions of the product. MDEV-36484 Atomic DDL: Assertion `!param->got_error' failed upon unsuccessful multi-RENAME TABLE

          • Major - Major loss of function.
          • In Review

          Activity

            Ascending order - Click to sort in descending order
            oleg.smirnov Oleg Smirnov added a comment -

            bar, can you please review bb-12.0-MDEV-36675-is-error?

            oleg.smirnov Oleg Smirnov added a comment - bar , can you please review bb-12.0- MDEV-36675 -is-error?
            bar Alexander Barkov added a comment -

            The patch https://github.com/MariaDB/server/commit/d151643b7f8ece6d347baea27f9c0ea49f825303 is OK to push.

            bar Alexander Barkov added a comment - The patch https://github.com/MariaDB/server/commit/d151643b7f8ece6d347baea27f9c0ea49f825303 is OK to push.
            oleg.smirnov Oleg Smirnov added a comment -

            The fix is pushed to feature branch bb-11.8-MDEV-34870-join-order.

            oleg.smirnov Oleg Smirnov added a comment - The fix is pushed to feature branch bb-11.8- MDEV-34870 -join-order.

            People

              oleg.smirnov Oleg Smirnov
              oleg.smirnov Oleg Smirnov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.