mariadb-binlog cannot process more than 1 logfiles when --stop-datetime is specified

Note

The fix for this issue has been submitted in https://github.com/MariaDB/server/pull/3670. Please review it and provide feedback on GitHub. I am willing to iterate on as many times as you want and with a quick turnaround.

Description

This is related to the behavior of mariadb-binlog, and the issue was introduced from minor versions (e.g 10.5.27, 10.6.20...) released on Nov 1, 2024

According to using-mariadb-binlog, mariadb-binlog should be able to process multiple log files when listing them all on the command line. For example:

shell> mariadb-binlog mariadb-bin.000001 mariadb-bin.000002

Since the affected versions, when multiple log files are specified, together with a --stop-datetime parameter value which is later than timestamp of the first log file, mariadb-binlog will exit after processing the first log file, and silently skip other log files. For example

shell> mariadb-binlog --stop-datetime="2024-11-30 18:52:00" mariadb-bin.000001 mariadb-bin.000002 mariadb-bin.000003

The result should include events from mariadb-bin.000001 to 000003. However, test result shows that it only returns events in mariadb-bin.000001

Analysis

This is related to 2 recent commits: commit1 and commit2 for MDEV-27037.

The changes set retval to OK_STOP after processing current log file and if not reached the boundary indicated by --stop-datetime or --stop-position

According to status definition, OK_STOP means it already reached the specified range of events to process, but in these 2 cases, it just reach the end of the log file, but not the specified --stop-datetime or --stop-position

@retval OK_STOP No error, but the end of the specified range of

  events to process has been reached and the program should terminate.

This causes a problem that in main method, after it processes first log file, it will exit from the for loop, because retval is OK_STOP now, instead of OK_CONTINUE as before, thus following log files will not be processed.

Proposed Fix

This problem should be fixed if we remove the code to set retval = OK_STOP in the new commits as below. While we may want to keep the code the emit warnings.

We will work on a fix and merge the code if no objections.

      /*

        Emit a warning in the event that we finished processing input

        before reaching the boundary indicated by --stop-position.

      */

      if (((longlong)stop_position != stop_position_default) &&

          stop_position > my_b_tell(file))

      {

--          retval = OK_STOP;

          warning("Did not reach stop position %llu before "

                  "end of input", stop_position);

      }

      /*

        Emit a warning in the event that we finished processing input

        before reaching the boundary indicated by --stop-datetime.

      */

      if (stop_datetime != MY_TIME_T_MAX &&

          stop_datetime > last_ev_when)

      {

--          retval = OK_STOP;

          warning("Did not reach stop datetime '%s' "

                  "before end of input", stop_datetime_str);

      }