Performance schema suffers from check-then act anti-pattern
For example init_setup_actor_hash:
if ((! setup_actor_hash_inited) && (param->m_setup_actor_sizing != 0))
|
{
|
lf_hash_init(&setup_actor_hash, sizeof(PFS_setup_actor*), LF_HASH_UNIQUE,
|
0, 0, setup_actor_hash_get_key, &my_charset_bin);
|
/* setup_actor_hash.size= param->m_setup_actor_sizing; */
|
setup_actor_hash_inited= true;
|
}
|
The compiler or CPU can reorder setup_actor_hash_inited initialization before lf_hash_init call.
At the same time, get_setup_actor_hash_pins
if (! setup_actor_hash_inited)
|
return NULL;
|
thread->m_setup_actor_hash_pins= lf_hash_get_pins(&setup_actor_hash);
|
can be called in parallel, resulting, in fact, in having garbage in setup_actor_hash.
Same for the other modules. Basically, everything called in
initialize_performance_schema is worth checking.
Probably, PFS_buffer_scalable_container's m_initialized is not affected.
- relates to
-
MDEV-28162
clang compiler emits atomic library calls on x86/32bit
-
-
Closed
{"report":{"fcp":797.7999999523163,"ttfb":127.09999990463257,"pageVisibility":"visible","entityId":129733,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"753e8c93-21ea-44c8-9781-1b2fcdfc5d36","navigationType":0,"readyForUser":849.5999999046326,"redirectCount":0,"resourceLoadedEnd":1034.3999998569489,"resourceLoadedStart":132.5,"resourceTiming":[{"duration":234.09999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":132.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":132.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":366.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":234.10000014305115,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":132.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":132.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":366.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":242.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":132.79999995231628,"connectEnd":132.79999995231628,"connectStart":132.79999995231628,"domainLookupEnd":132.79999995231628,"domainLookupStart":132.79999995231628,"fetchStart":132.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":132.79999995231628,"responseEnd":375.5,"responseStart":375.5,"secureConnectionStart":132.79999995231628},{"duration":267.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":132.89999985694885,"connectEnd":132.89999985694885,"connectStart":132.89999985694885,"domainLookupEnd":132.89999985694885,"domainLookupStart":132.89999985694885,"fetchStart":132.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":132.89999985694885,"responseEnd":400.69999980926514,"responseStart":400.69999980926514,"secureConnectionStart":132.89999985694885},{"duration":272,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":133,"connectEnd":133,"connectStart":133,"domainLookupEnd":133,"domainLookupStart":133,"fetchStart":133,"redirectEnd":0,"redirectStart":0,"requestStart":133,"responseEnd":405,"responseStart":405,"secureConnectionStart":133},{"duration":274,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":133.19999980926514,"connectEnd":133.19999980926514,"connectStart":133.19999980926514,"domainLookupEnd":133.19999980926514,"domainLookupStart":133.19999980926514,"fetchStart":133.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":133.19999980926514,"responseEnd":407.19999980926514,"responseStart":407.09999990463257,"secureConnectionStart":133.19999980926514},{"duration":273.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":133.19999980926514,"connectEnd":133.19999980926514,"connectStart":133.19999980926514,"domainLookupEnd":133.19999980926514,"domainLookupStart":133.19999980926514,"fetchStart":133.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":133.19999980926514,"responseEnd":406.69999980926514,"responseStart":406.69999980926514,"secureConnectionStart":133.19999980926514},{"duration":269.7000000476837,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":137.89999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":137.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":407.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":269.5,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":138.09999990463257,"connectEnd":138.09999990463257,"connectStart":138.09999990463257,"domainLookupEnd":138.09999990463257,"domainLookupStart":138.09999990463257,"fetchStart":138.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":138.09999990463257,"responseEnd":407.59999990463257,"responseStart":407.59999990463257,"secureConnectionStart":138.09999990463257},{"duration":269.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":138.19999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":138.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":408,"responseStart":0,"secureConnectionStart":0},{"duration":269.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":138.19999980926514,"connectEnd":138.19999980926514,"connectStart":138.19999980926514,"domainLookupEnd":138.19999980926514,"domainLookupStart":138.19999980926514,"fetchStart":138.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":138.19999980926514,"responseEnd":408.09999990463257,"responseStart":408.09999990463257,"secureConnectionStart":138.19999980926514},{"duration":529.1000001430511,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":139.69999980926514,"connectEnd":139.69999980926514,"connectStart":139.69999980926514,"domainLookupEnd":139.69999980926514,"domainLookupStart":139.69999980926514,"fetchStart":139.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":139.69999980926514,"responseEnd":668.7999999523163,"responseStart":668.7999999523163,"secureConnectionStart":139.69999980926514},{"duration":893.8999998569489,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":140.5,"connectEnd":140.5,"connectStart":140.5,"domainLookupEnd":140.5,"domainLookupStart":140.5,"fetchStart":140.5,"redirectEnd":0,"redirectStart":0,"requestStart":140.5,"responseEnd":1034.3999998569489,"responseStart":1034.3999998569489,"secureConnectionStart":140.5},{"duration":425.60000014305115,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":604.6999998092651,"connectEnd":604.6999998092651,"connectStart":604.6999998092651,"domainLookupEnd":604.6999998092651,"domainLookupStart":604.6999998092651,"fetchStart":604.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":604.6999998092651,"responseEnd":1030.2999999523163,"responseStart":1030.2999999523163,"secureConnectionStart":604.6999998092651},{"duration":270.2000000476837,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":775.2999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":775.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1045.5,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":7,"responseStart":127,"responseEnd":141,"domLoading":131,"domInteractive":1090,"domContentLoadedEventStart":1090,"domContentLoadedEventEnd":1124,"domComplete":1964,"loadEventStart":1964,"loadEventEnd":1966,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1074.8999998569489},{"name":"bigPipe.sidebar-id.end","time":1075.6999998092651},{"name":"bigPipe.activity-panel-pipe-id.start","time":1075.7999999523163},{"name":"bigPipe.activity-panel-pipe-id.end","time":1078.1999998092651},{"name":"activityTabFullyLoaded","time":1130.0999999046326}],"measures":[],"correlationId":"cd71ea2a6f6f9c","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":68,"dbReadsTimeInMs":9,"dbConnsTimeInMs":16,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}