Performance schema suffers from check-then act anti-pattern
For example init_setup_actor_hash:
if ((! setup_actor_hash_inited) && (param->m_setup_actor_sizing != 0))
|
{
|
lf_hash_init(&setup_actor_hash, sizeof(PFS_setup_actor*), LF_HASH_UNIQUE,
|
0, 0, setup_actor_hash_get_key, &my_charset_bin);
|
/* setup_actor_hash.size= param->m_setup_actor_sizing; */
|
setup_actor_hash_inited= true;
|
}
|
The compiler or CPU can reorder setup_actor_hash_inited initialization before lf_hash_init call.
At the same time, get_setup_actor_hash_pins
if (! setup_actor_hash_inited)
|
return NULL;
|
thread->m_setup_actor_hash_pins= lf_hash_get_pins(&setup_actor_hash);
|
can be called in parallel, resulting, in fact, in having garbage in setup_actor_hash.
Same for the other modules. Basically, everything called in
initialize_performance_schema is worth checking.
Probably, PFS_buffer_scalable_container's m_initialized is not affected.
- relates to
-
MDEV-28162
clang compiler emits atomic library calls on x86/32bit
-
-
Closed
{"report":{"fcp":782.8000001907349,"ttfb":173,"pageVisibility":"visible","entityId":129733,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"63750bff-b094-457d-8841-076ee8e859dd","navigationType":0,"readyForUser":895.2000000476837,"redirectCount":0,"resourceLoadedEnd":501.90000009536743,"resourceLoadedStart":181.60000014305115,"resourceTiming":[{"duration":4.799999952316284,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":181.60000014305115,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":181.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":186.40000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":4.900000095367432,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":181.90000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":181.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":186.80000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":206.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":182.10000014305115,"connectEnd":188.60000014305115,"connectStart":188.60000014305115,"domainLookupEnd":188.60000014305115,"domainLookupStart":188.60000014305115,"fetchStart":182.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":190,"responseEnd":388.90000009536743,"responseStart":253.30000019073486,"secureConnectionStart":188.60000014305115},{"duration":319.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":182.10000014305115,"connectEnd":182.10000014305115,"connectStart":182.10000014305115,"domainLookupEnd":182.10000014305115,"domainLookupStart":182.10000014305115,"fetchStart":182.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":190.70000004768372,"responseEnd":501.90000009536743,"responseStart":269,"secureConnectionStart":182.10000014305115},{"duration":41.60000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":182.20000004768372,"connectEnd":182.20000004768372,"connectStart":182.20000004768372,"domainLookupEnd":182.20000004768372,"domainLookupStart":182.20000004768372,"fetchStart":182.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":192.30000019073486,"responseEnd":223.80000019073486,"responseStart":221.80000019073486,"secureConnectionStart":182.20000004768372},{"duration":33,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":182.30000019073486,"connectEnd":182.30000019073486,"connectStart":182.30000019073486,"domainLookupEnd":182.30000019073486,"domainLookupStart":182.30000019073486,"fetchStart":182.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":193.90000009536743,"responseEnd":215.30000019073486,"responseStart":207.30000019073486,"secureConnectionStart":182.30000019073486},{"duration":35.89999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":182.30000019073486,"connectEnd":182.30000019073486,"connectStart":182.30000019073486,"domainLookupEnd":182.30000019073486,"domainLookupStart":182.30000019073486,"fetchStart":182.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":197.30000019073486,"responseEnd":218.20000004768372,"responseStart":211.60000014305115,"secureConnectionStart":182.30000019073486},{"duration":10.200000047683716,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":182.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":182.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":192.60000014305115,"responseStart":0,"secureConnectionStart":0},{"duration":39.10000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":182.5,"connectEnd":182.5,"connectStart":182.5,"domainLookupEnd":182.5,"domainLookupStart":182.5,"fetchStart":182.5,"redirectEnd":0,"redirectStart":0,"requestStart":200.20000004768372,"responseEnd":221.60000014305115,"responseStart":218.40000009536743,"secureConnectionStart":182.5},{"duration":14.200000047683716,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":182.70000004768372,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":182.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":196.90000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":39.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":182.80000019073486,"connectEnd":182.80000019073486,"connectStart":182.80000019073486,"domainLookupEnd":182.80000019073486,"domainLookupStart":182.80000019073486,"fetchStart":182.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":202.30000019073486,"responseEnd":222.30000019073486,"responseStart":219.20000004768372,"secureConnectionStart":182.80000019073486},{"duration":62.799999952316284,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":186.70000004768372,"connectEnd":186.70000004768372,"connectStart":186.70000004768372,"domainLookupEnd":186.70000004768372,"domainLookupStart":186.70000004768372,"fetchStart":186.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":221.20000004768372,"responseEnd":249.5,"responseStart":241.30000019073486,"secureConnectionStart":186.70000004768372},{"duration":310.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":187.30000019073486,"connectEnd":187.30000019073486,"connectStart":187.30000019073486,"domainLookupEnd":187.30000019073486,"domainLookupStart":187.30000019073486,"fetchStart":187.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":251.5,"responseEnd":497.80000019073486,"responseStart":494.5,"secureConnectionStart":187.30000019073486},{"duration":58.69999980926514,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":536.8000001907349,"connectEnd":536.8000001907349,"connectStart":536.8000001907349,"domainLookupEnd":536.8000001907349,"domainLookupStart":536.8000001907349,"fetchStart":536.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":562.1000001430511,"responseEnd":595.5,"responseStart":594.8000001907349,"secureConnectionStart":536.8000001907349},{"duration":113.09999990463257,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":775.8000001907349,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":775.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":888.9000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":136.20000004768372,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":782.7000000476837,"connectEnd":782.7000000476837,"connectStart":782.7000000476837,"domainLookupEnd":782.7000000476837,"domainLookupStart":782.7000000476837,"fetchStart":782.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":890.7000000476837,"responseEnd":918.9000000953674,"responseStart":917.8000001907349,"secureConnectionStart":782.7000000476837}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":29,"responseStart":173,"responseEnd":187,"domLoading":176,"domInteractive":952,"domContentLoadedEventStart":952,"domContentLoadedEventEnd":995,"domComplete":1361,"loadEventStart":1361,"loadEventEnd":1361,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":933.4000000953674},{"name":"bigPipe.sidebar-id.end","time":934.2000000476837},{"name":"bigPipe.activity-panel-pipe-id.start","time":934.3000001907349},{"name":"bigPipe.activity-panel-pipe-id.end","time":935.3000001907349},{"name":"activityTabFullyLoaded","time":1013.3000001907349}],"measures":[],"correlationId":"b43ea991995516","effectiveType":"4g","downlink":9.2,"rtt":0,"serverDuration":69,"dbReadsTimeInMs":11,"dbConnsTimeInMs":18,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Can I take this up?
I plan to start by creating a testcase which confirms the races.
I've figured out DEBUG_SYNC macro can be used to create the testcase, but I am unsure about how to access thread context in init_setup_actor_hash function.
Any clue on this?