Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-33728

remove use of MYSQL_VERSION_ID and MARIADB_BASE_VERSION in spider

Details

    Description

      They are from an age when spider was not in the mariadb source tree, and clutters the code.

      The changes can be generated by

      unifdef -DMYSQL_VERSION_ID=100400 -DMARIADB_BASE_VERSION -m storage/spider/spd_* storage/spider/ha_spider.* storage/spider/hs_client/*

      Attachments

        Issue Links

          relates to

          Technical task - A technical task. MDEV-27637 Spider: remove #if defined(MARIADB_BASE_VERSION) && MYSQL_VERSION_ID >= ${VERSION}

          • Major - Major loss of function.
          • Closed

          Technical task - A technical task. MDEV-27641 Spider: remove #if MYSQL_VERSION_ID < ${VERSION}

          • Major - Major loss of function.
          • Closed

          Technical task - A technical task. MDEV-27655 Spider: remove #ifdef MARIADB_BASE_VERSION

          • Major - Major loss of function.
          • Closed

          Activity

            Transition Time In Source Status Execution Times
            Yuchen Pei made transition -
            Open In Progress
            		22m 9s 1
            Yuchen Pei made transition -
            In Progress In Review
            		29s 1
            Alexey Botchkov made transition -
            In Review Stalled
            		18d 16h 44m 1
            Yuchen Pei made transition -
            Stalled Closed
            		10h 1m 1

            People

              ycp Yuchen Pei
              ycp Yuchen Pei
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.