Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-33360

fil_node_t::handle had better not be protected by fil_system.mutex

    XMLWordPrintable

Details

    • Bug
    • Status: Confirmed (View Workflow)
    • Major
    • Resolution: Unresolved
    • 10.5, 10.6, 10.7(EOL), 10.8(EOL), 10.9(EOL), 10.10(EOL), 10.11, 11.0(EOL), 11.1(EOL), 11.2(EOL), 11.3(EOL), 11.4
    • 10.6, 10.11, 11.4

    Description

      Currently, opening and closing InnoDB data files is protected by fil_system.mutex. Based on MDEV-32027, opening files may incur some overhead. Scalability could be better if opening and closing file handles was protected by the something in the fil_space_t of the affected tablespace, rather than by the InnoDB-wide fil_system.mutex.

      Initially I thought that we could use fil_space_t::latch, but it seems to be better to introduce a separate srw_mutex for protecting the file handles, because fil_space_t::latch can be held in operations that are allocating or freeing pages inside a tablespace. Such operations could involve page I/O, which in turn could require opening and closing data files.

      Attachments

        Issue Links

          Activity

            People

              vlad.lesin Vladislav Lesin
              marko Marko Mäkelä
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.