An encryption test failed on a mandatory builder:
|
10.5 c8346c0bacfdbe3fd61c67becff9934e75e08ed3
|
encryption.innodb-redo-nokeys 'ctr,innodb' w12 [ fail ]
|
...
|
2023-12-08 7:46:08 0 [Note] InnoDB: Starting crash recovery from checkpoint LSN=53205,1435867
|
2023-12-08 7:46:08 0 [ERROR] InnoDB: Recovery cannot access file ./test/t1.ibd (tablespace 5)
|
2023-12-08 7:46:08 0 [Note] InnoDB: You may set innodb_force_recovery=1 to ignore this and possibly get a corrupted database.
|
mariadbd: /home/buildbot/amd64-ubuntu-2204-debug-ps/build/storage/innobase/log/log0recv.cc:3510: dberr_t recv_recovery_from_checkpoint_start(lsn_t): Assertion `!recv_sys.found_corrupt_fs' failed.
|
This is reproducible also when attempting to start up 10.6 on a copy of the data directory (data.tar.xz
).
The code path that outputs the error message when processing a FILE_MODIFY record will also set recv_sys.found_corrupt_fs. This is triggered by a fil_ibd_load() return value FIL_LOAD_INVALID because of missing encryption information:
if (crypt_data && !crypt_data->is_key_found()) {
|
crypt_data->~fil_space_crypt_t();
|
ut_free(crypt_data);
|
return FIL_LOAD_INVALID;
|
}
|
In 10.6 the code is different:
if (crypt_data && !fil_crypt_check(crypt_data, filename)) {
|
return FIL_LOAD_INVALID;
|
}
|
All we need to do is to relax the too strict debug assertion:
diff --git a/storage/innobase/log/log0recv.cc b/storage/innobase/log/log0recv.cc
|
index d52a62cec99..05120871b0a 100644
|
--- a/storage/innobase/log/log0recv.cc
|
+++ b/storage/innobase/log/log0recv.cc
|
@@ -3507,7 +3507,7 @@ recv_recovery_from_checkpoint_start(lsn_t flush_lsn)
|
recv_group_scan_log_recs(checkpoint_lsn, &contiguous_lsn, false);
|
/* The first scan should not have stored or applied any records. */
|
ut_ad(recv_sys.pages.empty());
|
- ut_ad(!recv_sys.found_corrupt_fs);
|
+ ut_ad(!recv_sys.found_corrupt_fs || !srv_force_recovery);
|
|
if (srv_read_only_mode && recv_needed_recovery) {
|
mysql_mutex_unlock(&log_sys.mutex);
|
In this way, the server startup will fail gracefully, just like it is expected by the test:
|
10.5 c8346c0bacfdbe3fd61c67becff9934e75e08ed3 with patch
|
2023-12-08 10:47:50 0 [Note] InnoDB: Starting crash recovery from checkpoint LSN=53205,1435867
|
2023-12-08 10:47:50 0 [ERROR] InnoDB: Recovery cannot access file ./test/t1.ibd (tablespace 5)
|
2023-12-08 10:47:50 0 [Note] InnoDB: You may set innodb_force_recovery=1 to ignore this and possibly get a corrupted database.
|
2023-12-08 10:47:50 0 [ERROR] InnoDB: Missing FILE_CHECKPOINT at 1435867 between the checkpoint 53205 and the end 1501184.
|
2023-12-08 10:47:50 0 [ERROR] InnoDB: Plugin initialization aborted at srv0start.cc[1480] with error Generic error
|
2023-12-08 10:47:50 0 [Note] InnoDB: Starting shutdown...
|
2023-12-08 10:47:51 0 [ERROR] Plugin 'InnoDB' registration as a STORAGE ENGINE failed.
|
In 10.8, the log format was changed and the logic around FILE_CHECKPOINT was rewritten in MDEV-14425. We would still invoke fil_name_process() on the FILE_MODIFY records, and recv_sys.found_corrupt_fs could be set for a similar reason, but there is no assertion failure in recv_recovery_from_checkpoint_start() after the initial call to recv_scan_log(). In our CI systems, I only found this type of failure on the 10.5 and 10.6 branches.
- relates to
-
MDEV-14425
Change the InnoDB redo log format to reduce write amplification
-
-
Closed
There are no comments yet on this issue.
{"report":{"fcp":1177.7000000476837,"ttfb":165.5,"pageVisibility":"visible","entityId":126840,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"f186a2b6-9dd7-4966-83db-5a369c0ae31a","navigationType":0,"readyForUser":1268.5,"redirectCount":0,"resourceLoadedEnd":1505.5999999046326,"resourceLoadedStart":174.59999990463257,"resourceTiming":[{"duration":528.6000001430511,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":174.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":174.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":703.2000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":528.8000001907349,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":174.89999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":174.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":703.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":537.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":175,"connectEnd":175,"connectStart":175,"domainLookupEnd":175,"domainLookupStart":175,"fetchStart":175,"redirectEnd":0,"redirectStart":0,"requestStart":175,"responseEnd":712.7999999523163,"responseStart":712.7999999523163,"secureConnectionStart":175},{"duration":570.5999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":175.20000004768372,"connectEnd":175.20000004768372,"connectStart":175.20000004768372,"domainLookupEnd":175.20000004768372,"domainLookupStart":175.20000004768372,"fetchStart":175.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":175.20000004768372,"responseEnd":745.7999999523163,"responseStart":745.7999999523163,"secureConnectionStart":175.20000004768372},{"duration":574.0999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":175.5,"connectEnd":175.5,"connectStart":175.5,"domainLookupEnd":175.5,"domainLookupStart":175.5,"fetchStart":175.5,"redirectEnd":0,"redirectStart":0,"requestStart":175.5,"responseEnd":749.5999999046326,"responseStart":749.5,"secureConnectionStart":175.5},{"duration":574.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":175.59999990463257,"connectEnd":175.59999990463257,"connectStart":175.59999990463257,"domainLookupEnd":175.59999990463257,"domainLookupStart":175.59999990463257,"fetchStart":175.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":175.59999990463257,"responseEnd":749.8999998569489,"responseStart":749.8999998569489,"secureConnectionStart":175.59999990463257},{"duration":574.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":175.79999995231628,"connectEnd":175.79999995231628,"connectStart":175.79999995231628,"domainLookupEnd":175.79999995231628,"domainLookupStart":175.79999995231628,"fetchStart":175.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":175.79999995231628,"responseEnd":750.2999999523163,"responseStart":750.2999999523163,"secureConnectionStart":175.79999995231628},{"duration":680.2000000476837,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":176,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":176,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":856.2000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":574.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":176.09999990463257,"connectEnd":176.09999990463257,"connectStart":176.09999990463257,"domainLookupEnd":176.09999990463257,"domainLookupStart":176.09999990463257,"fetchStart":176.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":176.09999990463257,"responseEnd":750.7999999523163,"responseStart":750.7999999523163,"secureConnectionStart":176.09999990463257},{"duration":680.0999999046326,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":176.29999995231628,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":176.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":856.3999998569489,"responseStart":0,"secureConnectionStart":0},{"duration":575.1000001430511,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":176.39999985694885,"connectEnd":176.39999985694885,"connectStart":176.39999985694885,"domainLookupEnd":176.39999985694885,"domainLookupStart":176.39999985694885,"fetchStart":176.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":176.39999985694885,"responseEnd":751.5,"responseStart":751.5,"secureConnectionStart":176.39999985694885},{"duration":810.8999998569489,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":177.5,"connectEnd":177.5,"connectStart":177.5,"domainLookupEnd":177.5,"domainLookupStart":177.5,"fetchStart":177.5,"redirectEnd":0,"redirectStart":0,"requestStart":177.5,"responseEnd":988.3999998569489,"responseStart":988.3999998569489,"secureConnectionStart":177.5},{"duration":1294.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":181.5,"connectEnd":181.5,"connectStart":181.5,"domainLookupEnd":181.5,"domainLookupStart":181.5,"fetchStart":181.5,"redirectEnd":0,"redirectStart":0,"requestStart":181.5,"responseEnd":1476.2999999523163,"responseStart":1476.2999999523163,"secureConnectionStart":181.5},{"duration":128.19999980926514,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":884.2000000476837,"connectEnd":884.2000000476837,"connectStart":884.2000000476837,"domainLookupEnd":884.2000000476837,"domainLookupStart":884.2000000476837,"fetchStart":884.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":884.2000000476837,"responseEnd":1012.3999998569489,"responseStart":1012.3999998569489,"secureConnectionStart":884.2000000476837},{"duration":373.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1132.0999999046326,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1132.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1505.5999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":348.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1133,"connectEnd":1133,"connectStart":1133,"domainLookupEnd":1133,"domainLookupStart":1133,"fetchStart":1133,"redirectEnd":0,"redirectStart":0,"requestStart":1133,"responseEnd":1481.7999999523163,"responseStart":1481.7999999523163,"secureConnectionStart":1133},{"duration":355.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1133.3999998569489,"connectEnd":1133.3999998569489,"connectStart":1133.3999998569489,"domainLookupEnd":1133.3999998569489,"domainLookupStart":1133.3999998569489,"fetchStart":1133.3999998569489,"redirectEnd":0,"redirectStart":0,"requestStart":1133.3999998569489,"responseEnd":1488.7000000476837,"responseStart":1488.7000000476837,"secureConnectionStart":1133.3999998569489},{"duration":339.19999980926514,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1171.7000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1171.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1510.8999998569489,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":3,"responseStart":166,"responseEnd":174,"domLoading":172,"domInteractive":1536,"domContentLoadedEventStart":1536,"domContentLoadedEventEnd":1578,"domComplete":1637,"loadEventStart":1637,"loadEventEnd":1638,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1514.0999999046326},{"name":"bigPipe.sidebar-id.end","time":1514.8999998569489},{"name":"bigPipe.activity-panel-pipe-id.start","time":1515},{"name":"bigPipe.activity-panel-pipe-id.end","time":1515.5},{"name":"activityTabFullyLoaded","time":1587.3999998569489}],"measures":[],"correlationId":"4aab8bad3d859c","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":98,"dbReadsTimeInMs":11,"dbConnsTimeInMs":18,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Bug
Critical