An encryption test failed on a mandatory builder:
|
10.5 c8346c0bacfdbe3fd61c67becff9934e75e08ed3
|
encryption.innodb-redo-nokeys 'ctr,innodb' w12 [ fail ]
|
...
|
2023-12-08 7:46:08 0 [Note] InnoDB: Starting crash recovery from checkpoint LSN=53205,1435867
|
2023-12-08 7:46:08 0 [ERROR] InnoDB: Recovery cannot access file ./test/t1.ibd (tablespace 5)
|
2023-12-08 7:46:08 0 [Note] InnoDB: You may set innodb_force_recovery=1 to ignore this and possibly get a corrupted database.
|
mariadbd: /home/buildbot/amd64-ubuntu-2204-debug-ps/build/storage/innobase/log/log0recv.cc:3510: dberr_t recv_recovery_from_checkpoint_start(lsn_t): Assertion `!recv_sys.found_corrupt_fs' failed.
|
This is reproducible also when attempting to start up 10.6 on a copy of the data directory (data.tar.xz
).
The code path that outputs the error message when processing a FILE_MODIFY record will also set recv_sys.found_corrupt_fs. This is triggered by a fil_ibd_load() return value FIL_LOAD_INVALID because of missing encryption information:
if (crypt_data && !crypt_data->is_key_found()) {
|
crypt_data->~fil_space_crypt_t();
|
ut_free(crypt_data);
|
return FIL_LOAD_INVALID;
|
}
|
In 10.6 the code is different:
if (crypt_data && !fil_crypt_check(crypt_data, filename)) {
|
return FIL_LOAD_INVALID;
|
}
|
All we need to do is to relax the too strict debug assertion:
diff --git a/storage/innobase/log/log0recv.cc b/storage/innobase/log/log0recv.cc
|
index d52a62cec99..05120871b0a 100644
|
--- a/storage/innobase/log/log0recv.cc
|
+++ b/storage/innobase/log/log0recv.cc
|
@@ -3507,7 +3507,7 @@ recv_recovery_from_checkpoint_start(lsn_t flush_lsn)
|
recv_group_scan_log_recs(checkpoint_lsn, &contiguous_lsn, false);
|
/* The first scan should not have stored or applied any records. */
|
ut_ad(recv_sys.pages.empty());
|
- ut_ad(!recv_sys.found_corrupt_fs);
|
+ ut_ad(!recv_sys.found_corrupt_fs || !srv_force_recovery);
|
|
if (srv_read_only_mode && recv_needed_recovery) {
|
mysql_mutex_unlock(&log_sys.mutex);
|
In this way, the server startup will fail gracefully, just like it is expected by the test:
|
10.5 c8346c0bacfdbe3fd61c67becff9934e75e08ed3 with patch
|
2023-12-08 10:47:50 0 [Note] InnoDB: Starting crash recovery from checkpoint LSN=53205,1435867
|
2023-12-08 10:47:50 0 [ERROR] InnoDB: Recovery cannot access file ./test/t1.ibd (tablespace 5)
|
2023-12-08 10:47:50 0 [Note] InnoDB: You may set innodb_force_recovery=1 to ignore this and possibly get a corrupted database.
|
2023-12-08 10:47:50 0 [ERROR] InnoDB: Missing FILE_CHECKPOINT at 1435867 between the checkpoint 53205 and the end 1501184.
|
2023-12-08 10:47:50 0 [ERROR] InnoDB: Plugin initialization aborted at srv0start.cc[1480] with error Generic error
|
2023-12-08 10:47:50 0 [Note] InnoDB: Starting shutdown...
|
2023-12-08 10:47:51 0 [ERROR] Plugin 'InnoDB' registration as a STORAGE ENGINE failed.
|
In 10.8, the log format was changed and the logic around FILE_CHECKPOINT was rewritten in MDEV-14425. We would still invoke fil_name_process() on the FILE_MODIFY records, and recv_sys.found_corrupt_fs could be set for a similar reason, but there is no assertion failure in recv_recovery_from_checkpoint_start() after the initial call to recv_scan_log(). In our CI systems, I only found this type of failure on the 10.5 and 10.6 branches.
- relates to
-
MDEV-14425
Change the InnoDB redo log format to reduce write amplification
-
-
Closed
There are no comments yet on this issue.
{"report":{"fcp":1889.5999999046326,"ttfb":277.5,"pageVisibility":"visible","entityId":126840,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"7313435f-dba7-4c27-ae63-96f5a5fe1a39","navigationType":0,"readyForUser":1999.2000002861023,"redirectCount":0,"resourceLoadedEnd":1941.8000001907349,"resourceLoadedStart":285.5,"resourceTiming":[{"duration":934.5999999046326,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":285.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":285.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1220.0999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":935.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":285.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":285.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1221.3000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":1023,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":285.90000009536743,"connectEnd":285.90000009536743,"connectStart":285.90000009536743,"domainLookupEnd":285.90000009536743,"domainLookupStart":285.90000009536743,"fetchStart":285.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":285.90000009536743,"responseEnd":1308.9000000953674,"responseStart":1308.9000000953674,"secureConnectionStart":285.90000009536743},{"duration":1090.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":286.2000002861023,"connectEnd":286.2000002861023,"connectStart":286.2000002861023,"domainLookupEnd":286.2000002861023,"domainLookupStart":286.2000002861023,"fetchStart":286.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":286.2000002861023,"responseEnd":1376.5,"responseStart":1376.5,"secureConnectionStart":286.2000002861023},{"duration":1112.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":286.30000019073486,"connectEnd":286.30000019073486,"connectStart":286.30000019073486,"domainLookupEnd":286.30000019073486,"domainLookupStart":286.30000019073486,"fetchStart":286.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":286.30000019073486,"responseEnd":1399.2000002861023,"responseStart":1399.2000002861023,"secureConnectionStart":286.30000019073486},{"duration":1113.2000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":286.5,"connectEnd":286.5,"connectStart":286.5,"domainLookupEnd":286.5,"domainLookupStart":286.5,"fetchStart":286.5,"redirectEnd":0,"redirectStart":0,"requestStart":286.5,"responseEnd":1399.7000002861023,"responseStart":1399.7000002861023,"secureConnectionStart":286.5},{"duration":1113.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":286.7000002861023,"connectEnd":286.7000002861023,"connectStart":286.7000002861023,"domainLookupEnd":286.7000002861023,"domainLookupStart":286.7000002861023,"fetchStart":286.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":286.7000002861023,"responseEnd":1400.2000002861023,"responseStart":1400.2000002861023,"secureConnectionStart":286.7000002861023},{"duration":1215.9000000953674,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":286.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":286.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1502.7000002861023,"responseStart":0,"secureConnectionStart":0},{"duration":1114.0999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":287,"connectEnd":287,"connectStart":287,"domainLookupEnd":287,"domainLookupStart":287,"fetchStart":287,"redirectEnd":0,"redirectStart":0,"requestStart":287,"responseEnd":1401.0999999046326,"responseStart":1401.0999999046326,"secureConnectionStart":287},{"duration":1215.5999999046326,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":287.2000002861023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":287.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1502.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":1114.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":287.40000009536743,"connectEnd":287.40000009536743,"connectStart":287.40000009536743,"domainLookupEnd":287.40000009536743,"domainLookupStart":287.40000009536743,"fetchStart":287.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":287.40000009536743,"responseEnd":1402.3000001907349,"responseStart":1402.3000001907349,"secureConnectionStart":287.40000009536743},{"duration":1609,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":304.5,"connectEnd":304.5,"connectStart":304.5,"domainLookupEnd":304.5,"domainLookupStart":304.5,"fetchStart":304.5,"redirectEnd":0,"redirectStart":0,"requestStart":304.5,"responseEnd":1913.5,"responseStart":1913.5,"secureConnectionStart":304.5},{"duration":1637.2000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":304.59999990463257,"connectEnd":304.59999990463257,"connectStart":304.59999990463257,"domainLookupEnd":304.59999990463257,"domainLookupStart":304.59999990463257,"fetchStart":304.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":304.59999990463257,"responseEnd":1941.8000001907349,"responseStart":1941.8000001907349,"secureConnectionStart":304.59999990463257},{"duration":397.2000002861023,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1524.5,"connectEnd":1524.5,"connectStart":1524.5,"domainLookupEnd":1524.5,"domainLookupStart":1524.5,"fetchStart":1524.5,"redirectEnd":0,"redirectStart":0,"requestStart":1524.5,"responseEnd":1921.7000002861023,"responseStart":1921.7000002861023,"secureConnectionStart":1524.5},{"duration":227.7999997138977,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1872.3000001907349,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1872.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2100.0999999046326,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":121,"responseStart":277,"responseEnd":301,"domLoading":284,"domInteractive":2187,"domContentLoadedEventStart":2187,"domContentLoadedEventEnd":2258,"domComplete":2985,"loadEventStart":2985,"loadEventEnd":2986,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":2148},{"name":"bigPipe.sidebar-id.end","time":2149},{"name":"bigPipe.activity-panel-pipe-id.start","time":2149.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.end","time":2149.7000002861023},{"name":"activityTabFullyLoaded","time":2269.300000190735}],"measures":[],"correlationId":"a549692bd70b7f","effectiveType":"4g","downlink":9.6,"rtt":0,"serverDuration":93,"dbReadsTimeInMs":11,"dbConnsTimeInMs":20,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Bug
Critical