An encryption test failed on a mandatory builder :
10.5 c8346c0bacfdbe3fd61c67becff9934e75e08ed3
encryption.innodb-redo-nokeys 'ctr,innodb' w12 [ fail ]
...
2023-12-08 7:46:08 0 [Note] InnoDB: Starting crash recovery from checkpoint LSN=53205,1435867
2023-12-08 7:46:08 0 [ERROR] InnoDB: Recovery cannot access file ./test/t1.ibd (tablespace 5)
2023-12-08 7:46:08 0 [Note] InnoDB: You may set innodb_force_recovery=1 to ignore this and possibly get a corrupted database.
mariadbd: /home/buildbot/amd64-ubuntu-2204-debug-ps/build/storage/innobase/log/log0recv.cc:3510: dberr_t recv_recovery_from_checkpoint_start(lsn_t): Assertion `!recv_sys.found_corrupt_fs' failed.
This is reproducible also when attempting to start up 10.6 on a copy of the data directory (data.tar.xz FILE_MODIFY record will also set recv_sys.found_corrupt_fs . This is triggered by a fil_ibd_load() return value FIL_LOAD_INVALID because of missing encryption information:
if (crypt_data && !crypt_data->is_key_found()) {
crypt_data->~fil_space_crypt_t();
ut_free(crypt_data);
return FIL_LOAD_INVALID;
}
In 10.6 the code is different:
if (crypt_data && !fil_crypt_check(crypt_data, filename)) {
return FIL_LOAD_INVALID;
}
All we need to do is to relax the too strict debug assertion:
diff --git a/storage/innobase/log/log0recv.cc b/storage/innobase/log/log0recv.cc
index d52a62cec99..05120871b0a 100644
--- a/storage/innobase/log/log0recv.cc
+++ b/storage/innobase/log/log0recv.cc
@@ -3507,7 +3507,7 @@ recv_recovery_from_checkpoint_start(lsn_t flush_lsn)
recv_group_scan_log_recs(checkpoint_lsn, &contiguous_lsn, false);
/* The first scan should not have stored or applied any records. */
ut_ad(recv_sys.pages.empty());
- ut_ad(!recv_sys.found_corrupt_fs);
+ ut_ad(!recv_sys.found_corrupt_fs || !srv_force_recovery);
if (srv_read_only_mode && recv_needed_recovery) {
mysql_mutex_unlock(&log_sys.mutex);
In this way, the server startup will fail gracefully, just like it is expected by the test:
10.5 c8346c0bacfdbe3fd61c67becff9934e75e08ed3 with patch
2023-12-08 10:47:50 0 [Note] InnoDB: Starting crash recovery from checkpoint LSN=53205,1435867
2023-12-08 10:47:50 0 [ERROR] InnoDB: Recovery cannot access file ./test/t1.ibd (tablespace 5)
2023-12-08 10:47:50 0 [Note] InnoDB: You may set innodb_force_recovery=1 to ignore this and possibly get a corrupted database.
2023-12-08 10:47:50 0 [ERROR] InnoDB: Missing FILE_CHECKPOINT at 1435867 between the checkpoint 53205 and the end 1501184.
2023-12-08 10:47:50 0 [ERROR] InnoDB: Plugin initialization aborted at srv0start.cc[1480] with error Generic error
2023-12-08 10:47:50 0 [Note] InnoDB: Starting shutdown...
2023-12-08 10:47:51 0 [ERROR] Plugin 'InnoDB' registration as a STORAGE ENGINE failed.
In 10.8, the log format was changed and the logic around FILE_CHECKPOINT was rewritten in MDEV-14425 fil_name_process() on the FILE_MODIFY records, and recv_sys.found_corrupt_fs could be set for a similar reason, but there is no assertion failure in recv_recovery_from_checkpoint_start() after the initial call to recv_scan_log() . In our CI systems, I only found this type of failure on the 10.5 and 10.6 branches.
relates to
MDEV-14425
Change the InnoDB redo log format to reduce write amplification
Closed
made changes -
2023-12-08 08:53
Status
Open
[ 1
]
In Progress
[ 3
]
made changes -
2023-12-08 10:01
issue.field.resolutiondate
2023-12-08 10:01:55.0
2023-12-08 10:01:55.326
made changes -
2023-12-08 10:01
Fix Version/s
10.5.24
[ 29517
]
Fix Version/s
10.6.17
[ 29518
]
Fix Version/s
10.5
[ 23123
]
Fix Version/s
10.6
[ 24028
]
Resolution
Fixed
[ 1
]
Status
In Progress
[ 3
]
Closed
[ 6
]
{"report":{"fcp":1313.6000003814697,"ttfb":396,"pageVisibility":"visible","entityId":126840,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"08592817-dc37-4b33-9283-5c16b6daba7c","navigationType":0,"readyForUser":1421.4000005722046,"redirectCount":0,"resourceLoadedEnd":997.1000003814697,"resourceLoadedStart":401.9000005722046,"resourceTiming":[{"duration":119.59999942779541,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":401.9000005722046,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":401.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":521.5,"responseStart":0,"secureConnectionStart":0},{"duration":119.69999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":402.1000003814697,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":402.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":521.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":414,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":402.4000005722046,"connectEnd":402.4000005722046,"connectStart":402.4000005722046,"domainLookupEnd":402.4000005722046,"domainLookupStart":402.4000005722046,"fetchStart":402.4000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":525.5,"responseEnd":816.4000005722046,"responseStart":551.1000003814697,"secureConnectionStart":402.4000005722046},{"duration":591.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":402.5,"connectEnd":402.5,"connectStart":402.5,"domainLookupEnd":402.5,"domainLookupStart":402.5,"fetchStart":402.5,"redirectEnd":0,"redirectStart":0,"requestStart":527.1999998092651,"responseEnd":994,"responseStart":569,"secureConnectionStart":402.5},{"duration":154.4000005722046,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":402.69999980926514,"connectEnd":402.69999980926514,"connectStart":402.69999980926514,"domainLookupEnd":402.69999980926514,"domainLookupStart":402.69999980926514,"fetchStart":402.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":527.5,"responseEnd":557.1000003814697,"responseStart":554.6999998092651,"secureConnectionStart":402.69999980926514},{"duration":155,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":403,"connectEnd":403,"connectStart":403,"domainLookupEnd":403,"domainLookupStart":403,"fetchStart":403,"redirectEnd":0,"redirectStart":0,"requestStart":530.1000003814697,"responseEnd":558,"responseStart":555.6999998092651,"secureConnectionStart":403},{"duration":157.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":403.1000003814697,"connectEnd":403.1000003814697,"connectStart":403.1000003814697,"domainLookupEnd":403.1000003814697,"domainLookupStart":403.1000003814697,"fetchStart":403.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":531.3000001907349,"responseEnd":560.8000001907349,"responseStart":558.4000005722046,"secureConnectionStart":403.1000003814697},{"duration":127,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":403.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":403.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":530.3000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":161.5,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":403.5,"connectEnd":403.5,"connectStart":403.5,"domainLookupEnd":403.5,"domainLookupStart":403.5,"fetchStart":403.5,"redirectEnd":0,"redirectStart":0,"requestStart":537.5,"responseEnd":565,"responseStart":561.3000001907349,"secureConnectionStart":403.5},{"duration":127.40000057220459,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":403.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":403.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":531.1000003814697,"responseStart":0,"secureConnectionStart":0},{"duration":169.10000038146973,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":403.80000019073486,"connectEnd":403.80000019073486,"connectStart":403.80000019073486,"domainLookupEnd":403.80000019073486,"domainLookupStart":403.80000019073486,"fetchStart":403.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":538.3000001907349,"responseEnd":572.9000005722046,"responseStart":565.3000001907349,"secureConnectionStart":403.80000019073486},{"duration":584.5999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":409.9000005722046,"connectEnd":409.9000005722046,"connectStart":409.9000005722046,"domainLookupEnd":409.9000005722046,"domainLookupStart":409.9000005722046,"fetchStart":409.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":703.1000003814697,"responseEnd":994.5,"responseStart":988.3000001907349,"secureConnectionStart":409.9000005722046},{"duration":587.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":409.9000005722046,"connectEnd":409.9000005722046,"connectStart":409.9000005722046,"domainLookupEnd":409.9000005722046,"domainLookupStart":409.9000005722046,"fetchStart":409.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":866.1999998092651,"responseEnd":997.1000003814697,"responseStart":991.6000003814697,"secureConnectionStart":409.9000005722046},{"duration":222.4000005722046,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":958,"connectEnd":958,"connectStart":958,"domainLookupEnd":958,"domainLookupStart":958,"fetchStart":958,"redirectEnd":0,"redirectStart":0,"requestStart":1147,"responseEnd":1180.4000005722046,"responseStart":1179.6999998092651,"secureConnectionStart":958}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":190,"responseStart":396,"responseEnd":407,"domLoading":400,"domInteractive":1535,"domContentLoadedEventStart":1535,"domContentLoadedEventEnd":1593,"domComplete":2226,"loadEventStart":2226,"loadEventEnd":2227,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1505.5},{"name":"bigPipe.sidebar-id.end","time":1506.1999998092651},{"name":"bigPipe.activity-panel-pipe-id.start","time":1506.4000005722046},{"name":"bigPipe.activity-panel-pipe-id.end","time":1508.1999998092651},{"name":"activityTabFullyLoaded","time":1609.1000003814697}],"measures":[],"correlationId":"8c9123ad12639e","effectiveType":"4g","downlink":9.3,"rtt":0,"serverDuration":115,"dbReadsTimeInMs":17,"dbConnsTimeInMs":26,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Bug
Critical
).MDEV-14425 Change the InnoDB redo log format to reduce write amplification
