Revert the replication part of this commit:
commit 6b685ea7b0776430d45b095cb4be3ef0739a3c04
|
Author: Sergei Golubchik <serg@mariadb.org>
|
Date: Wed Sep 28 18:55:15 2022 +0200
|
|
correctness assert
|
|
thd_get_ha_data() can be used without a lock, but only from the
|
current thd thread, when calling from anoher thread it *must*
|
be protected by thd->LOCK_thd_data
|
|
* fix group commit code to take thd->LOCK_thd_data
|
The group commit code must not take thd->LOCK_thd_data over run_commit_ordered().
The thd is at this point temporarily transferred to the current thread. Taking LOCK_thd_data incurs a performance penalty for every (binlog) commit. Worse, if any storage engine code implementing the commit_ordered handlerton call would try to take the mutex (to modify THD data), the server would deadlock on a recursive mutex take.
Instead, set_current_thd() for the duration of the commit_ordered call. If any code should access the current_thd, the correct value is the THD of the transaction being committed here, not the THD of the group commit leader.
Mailing list thread: https://lists.mariadb.org/hyperkitty/list/developers@lists.mariadb.org/thread/TPJ5RI2F2QFX5T6QWZZIETVC3RNOYPVC/
{"report":{"fcp":970.2000007629395,"ttfb":332.80000019073486,"pageVisibility":"visible","entityId":126179,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"151532f3-0b7d-4be5-9756-8844516b827d","navigationType":0,"readyForUser":1038.5,"redirectCount":0,"resourceLoadedEnd":976.6000003814697,"resourceLoadedStart":338.20000076293945,"resourceTiming":[{"duration":70.79999923706055,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":338.20000076293945,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":338.20000076293945,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":409,"responseStart":0,"secureConnectionStart":0},{"duration":71.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":338.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":338.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":409.80000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":126.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":338.6000003814697,"connectEnd":338.6000003814697,"connectStart":338.6000003814697,"domainLookupEnd":338.6000003814697,"domainLookupStart":338.6000003814697,"fetchStart":338.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":338.6000003814697,"responseEnd":464.80000019073486,"responseStart":464.80000019073486,"secureConnectionStart":338.6000003814697},{"duration":224.4000005722046,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":338.80000019073486,"connectEnd":338.80000019073486,"connectStart":338.80000019073486,"domainLookupEnd":338.80000019073486,"domainLookupStart":338.80000019073486,"fetchStart":338.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":338.80000019073486,"responseEnd":563.2000007629395,"responseStart":563.2000007629395,"secureConnectionStart":338.80000019073486},{"duration":227.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":339.1000003814697,"connectEnd":339.1000003814697,"connectStart":339.1000003814697,"domainLookupEnd":339.1000003814697,"domainLookupStart":339.1000003814697,"fetchStart":339.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":339.1000003814697,"responseEnd":566.9000005722046,"responseStart":566.9000005722046,"secureConnectionStart":339.1000003814697},{"duration":228.0999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":339.20000076293945,"connectEnd":339.20000076293945,"connectStart":339.20000076293945,"domainLookupEnd":339.20000076293945,"domainLookupStart":339.20000076293945,"fetchStart":339.20000076293945,"redirectEnd":0,"redirectStart":0,"requestStart":339.20000076293945,"responseEnd":567.3000001907349,"responseStart":567.3000001907349,"secureConnectionStart":339.20000076293945},{"duration":228.4000005722046,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":339.30000019073486,"connectEnd":339.30000019073486,"connectStart":339.30000019073486,"domainLookupEnd":339.30000019073486,"domainLookupStart":339.30000019073486,"fetchStart":339.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":339.30000019073486,"responseEnd":567.7000007629395,"responseStart":567.7000007629395,"secureConnectionStart":339.30000019073486},{"duration":267.70000076293945,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":339.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":339.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":607.2000007629395,"responseStart":0,"secureConnectionStart":0},{"duration":228.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":339.80000019073486,"connectEnd":339.80000019073486,"connectStart":339.80000019073486,"domainLookupEnd":339.80000019073486,"domainLookupStart":339.80000019073486,"fetchStart":339.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":339.80000019073486,"responseEnd":568.1000003814697,"responseStart":568.1000003814697,"secureConnectionStart":339.80000019073486},{"duration":267.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":339.9000005722046,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":339.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":607.4000005722046,"responseStart":0,"secureConnectionStart":0},{"duration":228.60000038146973,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":340,"connectEnd":340,"connectStart":340,"domainLookupEnd":340,"domainLookupStart":340,"fetchStart":340,"redirectEnd":0,"redirectStart":0,"requestStart":340,"responseEnd":568.6000003814697,"responseStart":568.6000003814697,"secureConnectionStart":340},{"duration":419.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":340.80000019073486,"connectEnd":340.80000019073486,"connectStart":340.80000019073486,"domainLookupEnd":340.80000019073486,"domainLookupStart":340.80000019073486,"fetchStart":340.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":340.80000019073486,"responseEnd":760.5,"responseStart":760.5,"secureConnectionStart":340.80000019073486},{"duration":633.3999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":340.9000005722046,"connectEnd":340.9000005722046,"connectStart":340.9000005722046,"domainLookupEnd":340.9000005722046,"domainLookupStart":340.9000005722046,"fetchStart":340.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":340.9000005722046,"responseEnd":974.3000001907349,"responseStart":974.3000001907349,"secureConnectionStart":340.9000005722046},{"duration":142,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":618.8000001907349,"connectEnd":618.8000001907349,"connectStart":618.8000001907349,"domainLookupEnd":618.8000001907349,"domainLookupStart":618.8000001907349,"fetchStart":618.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":618.8000001907349,"responseEnd":760.8000001907349,"responseStart":760.8000001907349,"secureConnectionStart":618.8000001907349},{"duration":103.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":873.2000007629395,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":873.2000007629395,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":976.4000005722046,"responseStart":0,"secureConnectionStart":0},{"duration":102.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/50bc9be5bfead1a25e72c1a9338c94f6-CDN/lu2cib/820016/12ta74/03ec8e95fb0700cf309083e2358eb54b/_/download/contextbatch/css/com.atlassian.jira.plugins.jira-development-integration-plugin:0,com.atlassian.jira.plugins.jira-quicksearch-plugin:5,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":873.8000001907349,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":873.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":976.6000003814697,"responseStart":0,"secureConnectionStart":0},{"duration":230,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":874.5,"connectEnd":874.5,"connectStart":874.5,"domainLookupEnd":874.5,"domainLookupStart":874.5,"fetchStart":874.5,"redirectEnd":0,"redirectStart":0,"requestStart":874.5,"responseEnd":1104.5,"responseStart":1104.5,"secureConnectionStart":874.5},{"duration":235.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d44aa1ee0c678dcc675ac6ce6f14e4a-CDN/lu2cib/820016/12ta74/03ec8e95fb0700cf309083e2358eb54b/_/download/contextbatch/js/com.atlassian.jira.plugins.jira-development-integration-plugin:0,com.atlassian.jira.plugins.jira-quicksearch-plugin:5,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":875.3000001907349,"connectEnd":875.3000001907349,"connectStart":875.3000001907349,"domainLookupEnd":875.3000001907349,"domainLookupStart":875.3000001907349,"fetchStart":875.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":875.3000001907349,"responseEnd":1111.1000003814697,"responseStart":1111.1000003814697,"secureConnectionStart":875.3000001907349},{"duration":234.70000076293945,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":875,"connectEnd":875,"connectStart":875,"domainLookupEnd":875,"domainLookupStart":875,"fetchStart":875,"redirectEnd":0,"redirectStart":0,"requestStart":875,"responseEnd":1109.7000007629395,"responseStart":1109.7000007629395,"secureConnectionStart":875}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":134,"responseStart":333,"responseEnd":336,"domLoading":336,"domInteractive":1082,"domContentLoadedEventStart":1082,"domContentLoadedEventEnd":1118,"domComplete":1297,"loadEventStart":1297,"loadEventEnd":1300,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1072.6000003814697},{"name":"bigPipe.sidebar-id.end","time":1073.4000005722046},{"name":"bigPipe.activity-panel-pipe-id.start","time":1073.6000003814697},{"name":"bigPipe.activity-panel-pipe-id.end","time":1074.3000001907349},{"name":"activityTabFullyLoaded","time":1136}],"measures":[],"correlationId":"2be2b337429c5d","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":128,"dbReadsTimeInMs":9,"dbConnsTimeInMs":17,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Pushed to 10.5.