[MDEV-32672] Don't hold LOCK_thd_data over commit_ordered Created: 2023-11-03 Updated: 2023-11-03 Resolved: 2023-11-03 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Replication |
| Affects Version/s: | 10.4.31 |
| Fix Version/s: | 10.5.24, 10.6.17, 10.11.7, 11.0.5, 11.1.4, 11.2.3, 11.3.2 |
| Type: | Bug | Priority: | Major |
| Reporter: | Kristian Nielsen | Assignee: | Kristian Nielsen |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
Revert the replication part of this commit:
The group commit code must not take thd->LOCK_thd_data over run_commit_ordered(). Instead, set_current_thd() for the duration of the commit_ordered call. If any code should access the current_thd, the correct value is the THD of the transaction being committed here, not the THD of the group commit leader. Mailing list thread: https://lists.mariadb.org/hyperkitty/list/developers@lists.mariadb.org/thread/TPJ5RI2F2QFX5T6QWZZIETVC3RNOYPVC/ |
| Comments |
| Comment by Kristian Nielsen [ 2023-11-03 ] |
|
Pushed to 10.5. |