Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-32526

Enable Charset Narrowing by default starting from 11.3

Details

    Description

      MDEV-32113 has introduced charset narrowing optimization.

      It was introduced in 10.6 and it is not enabled by default.

      We should enable it by default. It should be done in 11.4 as its the earliest development release.

      Also, we should consider removing the optimizer switch flag (either in this or in a later version).

      Attachments

        Issue Links

          Activity

            serg, I now see it has been already done in 11.3 by:

            commit e987b9350cb83038c73a165922986441f345a3a9
            Author:	Sergei Petrunia <sergey@mariadb.com>  Mon Jun 19 17:53:16 2023
            Committer:	Sergei Petrunia <sergey@mariadb.com>  Tue Sep 12 17:14:43 2023
             
            MDEV-31496: Make optimizer handle UCASE(varchar_col)=...
            

            The backport to 10.6 was done after

            commit 4941ac9192394a1489f0bf01b6dd2ee5ec2906c9 (origin/bb-10.6-mdev32113-variant3, bb-10.6-mdev32113-variant3)
            Author: Sergei Petrunia <sergey@mariadb.com>
            Date:   Tue Sep 19 18:22:49 2023 +0300
             
                MDEV-32113: utf8mb3_key_col=utf8mb4_value cannot be used for ref
            

            psergei Sergei Petrunia added a comment - serg , I now see it has been already done in 11.3 by: commit e987b9350cb83038c73a165922986441f345a3a9 Author: Sergei Petrunia <sergey@mariadb.com> Mon Jun 19 17:53:16 2023 Committer: Sergei Petrunia <sergey@mariadb.com> Tue Sep 12 17:14:43 2023   MDEV-31496: Make optimizer handle UCASE(varchar_col)=... The backport to 10.6 was done after commit 4941ac9192394a1489f0bf01b6dd2ee5ec2906c9 (origin/bb-10.6-mdev32113-variant3, bb-10.6-mdev32113-variant3) Author: Sergei Petrunia <sergey@mariadb.com> Date: Tue Sep 19 18:22:49 2023 +0300   MDEV-32113: utf8mb3_key_col=utf8mb4_value cannot be used for ref

            Somehow this just didnt get done:

            select version();
            version()
            11.3.3-MariaDB-debug-log
            call sys.optimizer_switch_off();
            option  opt
            cset_narrowing  off
            index_merge_sort_intersection   off
            mrr     off
            mrr_cost_based  off
            mrr_sort_keys   off
            not_null_range_scan     off
            

            psergei Sergei Petrunia added a comment - Somehow this just didnt get done: select version(); version() 11.3.3-MariaDB-debug-log call sys.optimizer_switch_off(); option opt cset_narrowing off index_merge_sort_intersection off mrr off mrr_cost_based off mrr_sort_keys off not_null_range_scan off

            This was fixed in 11.7 by MDEV-34380

            psergei Sergei Petrunia added a comment - This was fixed in 11.7 by MDEV-34380

            People

              psergei Sergei Petrunia
              psergei Sergei Petrunia
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.