Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-32507

Spider tests with init-file using $MYSQL_TEST_DIR fails in certain CIs due to different directory structure

Details

    Description

      Example:

      https://buildbot.mariadb.net/buildbot/builders/kvm-deb-bullseye-amd64/builds/3107

      The mtr failures all have to do with the $MYSQL_TEST_DIR being /usr/share/mysql/mysql-test on the CI machine, whose parent dir does not contain storage/spider/mysql-test, so paths like the one in --init-file=$MYSQL_TEST_DIR/../storage/spider/mysql-test/spider/bugfix/t/mdev_28218_mixed.sql are not found.

      Attachments

        Issue Links

          is caused by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-22979 "mysqld --bootstrap" / mysql_install_db hangs when Spider is installed

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            ycp Yuchen Pei added a comment - - edited

            An initial fix, waiting for CI builders to pick it up

            bb-10.10-mdev-3250X upstream/bb-10.10-all-builders f63845524aacdd06431399c857c93aa52559b76c
            		 
            [fixup] Spider: Use $MTR_SUITE_DIR for init-file files
            		 
             
            		 
            This should fix certain CI builds where the spider suite test files
            		 
            and the main suite test files do not follow the same relative paths
            		 
            relations as the mariadb source.

            https://buildbot.mariadb.net/buildbot/grid?category=main&branch=bb-10.10-all-builders
            https://buildbot.mariadb.net/buildbot/builders/kvm-deb-bullseye-amd64/builds/3143

            Update on [2023-10-19 Thu]: the fix worked, as the failures caused
            by this issue are gone. There's still failure in
            spider/bugfix.mdev_30370 but that is a separate issue, for which I
            have opened MDEV-32515.

            ycp Yuchen Pei added a comment - - edited An initial fix, waiting for CI builders to pick it up bb-10.10-mdev-3250X upstream/bb-10.10-all-builders f63845524aacdd06431399c857c93aa52559b76c [fixup] Spider: Use $MTR_SUITE_DIR for init-file files   This should fix certain CI builds where the spider suite test files and the main suite test files do not follow the same relative paths relations as the mariadb source. https://buildbot.mariadb.net/buildbot/grid?category=main&branch=bb-10.10-all-builders https://buildbot.mariadb.net/buildbot/builders/kvm-deb-bullseye-amd64/builds/3143 Update on [2023-10-19 Thu] : the fix worked, as the failures caused by this issue are gone. There's still failure in spider/bugfix.mdev_30370 but that is a separate issue, for which I have opened MDEV-32515 .
            ycp Yuchen Pei added a comment -

            Hi holyfoot, ptal thanks

            upstream/bb-10.10-mdev-32507 bb-10.10-all-builders e776d00fb2027183240d3b932b3394c2f923f1b7
            		 
            MDEV-32507 Spider: Use $MTR_SUITE_DIR for init-file files
            		 
             
            		 
            This should fix certain CI builds where the spider suite test files
            		 
            and the main suite test files do not follow the same relative paths
            		 
            relations as the mariadb source.

            ycp Yuchen Pei added a comment - Hi holyfoot , ptal thanks upstream/bb-10.10-mdev-32507 bb-10.10-all-builders e776d00fb2027183240d3b932b3394c2f923f1b7 MDEV-32507 Spider: Use $MTR_SUITE_DIR for init-file files   This should fix certain CI builds where the spider suite test files and the main suite test files do not follow the same relative paths relations as the mariadb source.
            holyfoot Alexey Botchkov added a comment -

            ok to push.

            holyfoot Alexey Botchkov added a comment - ok to push.
            ycp Yuchen Pei added a comment -

            Thanks for the review.

            Pushed 15a1168b36e to 10.10

            ycp Yuchen Pei added a comment - Thanks for the review. Pushed 15a1168b36e to 10.10

            People

              ycp Yuchen Pei
              ycp Yuchen Pei
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.