Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-32462

mysql_upgrade -s still checks for non system tables

Details

    Description

      mysql_upgrade -s is supposed to just check system tables, and leave customer tables alone. well, this does not seem the case:

      | 918965 | root | localhost | mysql | Query   |  244 | checking permissions | SELECT table_comment FROM information_schema.tables WHERE table_comment LIKE 'Unknown data type: %' |    0.000 |

      this is not expected and on a database with millions of tables, can take a VERY long time.

      We need to respect the "-s" flag and just check system tables.

      Attachments

        Issue Links

          is caused by

          Task - A task that needs to be done. MDEV-24093 Detect during mysql_upgrade if type_mysql_json.so is needed and load it

          • Major - Major loss of function.
          • Closed
          links to

          Web Link PR 2790

          Activity

            Ascending order - Click to sort in descending order
            danblack Daniel Black added a comment -

            The query isn't updating system tables, but looking for datatypes.

            The effect is the same, its opening all tables.

            When -s, is used, this could be restricted to just the mysql database.

            danblack Daniel Black added a comment - The query isn't updating system tables, but looking for datatypes. The effect is the same, its opening all tables. When -s , is used, this could be restricted to just the mysql database.
            rpizzi Rick Pizzi (Inactive) added a comment -

            Right. Just restrict any check/operation to the mysql database.

            rpizzi Rick Pizzi (Inactive) added a comment - Right. Just restrict any check/operation to the mysql database.
            danblack Daniel Black added a comment -

            Thanks anel for pr 2790.

            cvicentiu assigning second review to you.

            danblack Daniel Black added a comment - Thanks anel for pr 2790. cvicentiu assigning second review to you.
            danblack Daniel Black added a comment -

            This now doesn't check system tables for unidentified types when -s is specified.

            danblack Daniel Black added a comment - This now doesn't check system tables for unidentified types when -s is specified.

            People

              cvicentiu Vicențiu Ciorbaru
              rpizzi Rick Pizzi (Inactive)
              Votes:
              4 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.