[#MDEV-32462] mysql_upgrade -s still checks for non system tables

[MDEV-32462] mysql_upgrade -s still checks for non system tables Created: 2023-10-13 Updated: 2023-11-13 Resolved: 2023-10-30
Status:	Closed
Project:	MariaDB Server
Component/s:	Server, Upgrades
Affects Version/s:	10.5.22
Fix Version/s:	10.5.24, 10.6.17, 10.11.7, 11.0.5, 11.1.4

Type:

Bug

Priority:

Critical

Reporter:

Rick Pizzi

Assignee:

Vicențiu Ciorbaru

Resolution:

Fixed

Votes:

Labels:

regression

Issue Links:

Problem/Incident
is caused by	~~MDEV-24093~~	Detect during mysql_upgrade if type_m...	Closed

Description

mysql_upgrade -s is supposed to just check system tables, and leave customer tables alone. well, this does not seem the case:

| 918965 | root | localhost | mysql | Query   |  244 | checking permissions | SELECT table_comment FROM information_schema.tables WHERE table_comment LIKE 'Unknown data type: %' |    0.000 |

this is not expected and on a database with millions of tables, can take a VERY long time.

We need to respect the "-s" flag and just check system tables.

Comments

Comment by Daniel Black [ 2023-10-13 ]

The query isn't updating system tables, but looking for datatypes.

The effect is the same, its opening all tables.

When -s, is used, this could be restricted to just the mysql database.

Comment by Rick Pizzi [ 2023-10-13 ]

Right. Just restrict any check/operation to the mysql database.

Comment by Daniel Black [ 2023-10-18 ]

Thanks anel for pr 2790.

cvicentiu assigning second review to you.

Comment by Daniel Black [ 2023-10-30 ]

This now doesn't check system tables for unidentified types when -s is specified.

Generated at Thu Feb 08 10:31:32 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.

[MDEV-32462] mysql_upgrade -s still checks for non system tables Created: 2023-10-13 Updated: 2023-11-13 Resolved: 2023-10-30