Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-32462

mysql_upgrade -s still checks for non system tables

Details

    Description

      mysql_upgrade -s is supposed to just check system tables, and leave customer tables alone. well, this does not seem the case:

      | 918965 | root | localhost | mysql | Query   |  244 | checking permissions | SELECT table_comment FROM information_schema.tables WHERE table_comment LIKE 'Unknown data type: %' |    0.000 |

      this is not expected and on a database with millions of tables, can take a VERY long time.

      We need to respect the "-s" flag and just check system tables.

      Attachments

        Issue Links

          is caused by

          Task - A task that needs to be done. MDEV-24093 Detect during mysql_upgrade if type_mysql_json.so is needed and load it

          • Major - Major loss of function.
          • Closed
          links to

          Web Link PR 2790

          Activity

            Ascending order - Click to sort in descending order
            rpizzi Rick Pizzi (Inactive) created issue -
            danblack Daniel Black added a comment -

            The query isn't updating system tables, but looking for datatypes.

            The effect is the same, its opening all tables.

            When -s, is used, this could be restricted to just the mysql database.

            danblack Daniel Black added a comment - The query isn't updating system tables, but looking for datatypes. The effect is the same, its opening all tables. When -s , is used, this could be restricted to just the mysql database.
            danblack Daniel Black made changes -
            Field Original Value New Value
            danblack Daniel Black made changes -
            Assignee Anel Husakovic [ anel ]
            danblack Daniel Black made changes -
            Labels regression
            danblack Daniel Black made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            rpizzi Rick Pizzi (Inactive) added a comment -

            Right. Just restrict any check/operation to the mysql database.

            rpizzi Rick Pizzi (Inactive) added a comment - Right. Just restrict any check/operation to the mysql database.
            anel Anel Husakovic made changes -
            Fix Version/s 10.5.23 [ 29012 ]
            Fix Version/s 10.6.16 [ 29014 ]
            Fix Version/s 10.9.8 [ 29015 ]
            Fix Version/s 10.8.8 [ 28518 ]
            anel Anel Husakovic made changes -
            Status Open [ 1 ] Confirmed [ 10101 ]
            anel Anel Husakovic made changes -
            Assignee Anel Husakovic [ anel ] Daniel Black [ danblack ]
            Status Confirmed [ 10101 ] In Review [ 10002 ]
            anel Anel Husakovic made changes -
            danblack Daniel Black made changes -
            Assignee Daniel Black [ danblack ] Vicențiu Ciorbaru [ cvicentiu ]
            danblack Daniel Black added a comment -

            Thanks anel for pr 2790.

            cvicentiu assigning second review to you.

            danblack Daniel Black added a comment - Thanks anel for pr 2790. cvicentiu assigning second review to you.
            serg Sergei Golubchik made changes -
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.10 [ 27530 ]
            Fix Version/s 10.11 [ 27614 ]
            Fix Version/s 11.0 [ 28320 ]
            Fix Version/s 11.1 [ 28549 ]
            Fix Version/s 10.8.8 [ 28518 ]
            Fix Version/s 10.5.23 [ 29012 ]
            Fix Version/s 10.6.16 [ 29014 ]
            Fix Version/s 10.9.8 [ 29015 ]
            anel Anel Husakovic made changes -
            Fix Version/s 10.5.23 [ 29012 ]
            Fix Version/s 10.6.16 [ 29014 ]
            Fix Version/s 10.10.7 [ 29018 ]
            Fix Version/s 10.11.6 [ 29020 ]
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.10 [ 27530 ]
            Fix Version/s 10.11 [ 27614 ]
            Fix Version/s 11.0 [ 28320 ]
            Fix Version/s 11.1 [ 28549 ]
            Resolution Fixed [ 1 ]
            Status In Review [ 10002 ] Closed [ 6 ]
            JIraAutomate JiraAutomate made changes -
            Fix Version/s 11.0.4 [ 29021 ]
            Fix Version/s 11.1.3 [ 29023 ]
            danblack Daniel Black added a comment -

            This now doesn't check system tables for unidentified types when -s is specified.

            danblack Daniel Black added a comment - This now doesn't check system tables for unidentified types when -s is specified.
            dbart Daniel Bartholomew made changes -
            Fix Version/s 10.5.24 [ 29517 ]
            Fix Version/s 10.6.17 [ 29518 ]
            Fix Version/s 10.11.7 [ 29519 ]
            Fix Version/s 11.0.5 [ 29520 ]
            Fix Version/s 11.1.4 [ 29024 ]
            Fix Version/s 10.5.23 [ 29012 ]
            Fix Version/s 10.6.16 [ 29014 ]
            Fix Version/s 10.10.7 [ 29018 ]
            Fix Version/s 10.11.6 [ 29020 ]
            Fix Version/s 11.0.4 [ 29021 ]
            Fix Version/s 11.1.3 [ 29023 ]

            People

              cvicentiu Vicențiu Ciorbaru
              rpizzi Rick Pizzi (Inactive)
              Votes:
              4 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.