Details
-
Task
-
Status: Closed (View Workflow)
-
Critical
-
Resolution: Fixed
-
None
Description
This serves as a workaround for many bugs caused by the spider group
by handler (GBH) (labeled with spider-gbh). There is a system
variable spider_use_handler that could disable the group by
handler if it is set to 1*, but it was deprecated, and then deleted
in 10.10+ (MDEV-27256). So we could add
spider_disable_group_by_handler to 10.10+.
For context, see a comment in MDEV-26247[1]:
Here's a little demo showing disabling the spider GBH "fixes" the
issue. It could be a fallback / workaround, and it would be
interesting to see which other gbh bugs can also be mitigated by
this workaround.637c1a3c315 upstream/bb-11.0-ycp-mdev-26247-disable-gbh
MDEV-26247[demo] disabling the spider gbh fixes the issueupdate on [2023-09-22 Fri]: I confirm that all other bugs current
labeled with spider-gbh can be mitigated by this workaround:So it makes sense to add a system variable e.g.
spider_disable_group_by_handler.
*: When spider_use_handler is set to 1, it skips creating
conn_holder on spider fields which causes the return of a NULL
pointer in spider_create_group_by_hander().
Attachments
Issue Links
- duplicates
-
MDEV-26364 Add Spider server variable for disabling GROUP BY handler
- Closed
- relates to
-
MDEV-32246 Add tests to spider-gbh tickets for 10.4-6 with the spider_use_handler workaround
- Open
-
MDEV-26247 Spider: Valid LEFT JOIN results in ERROR 1064
- Closed
-
MDEV-28998 ASAN errors in spider_fields::free_conn_holder or spider_create_group_by_handler
- Closed
-
MDEV-29163 Server crash with SIGSEGV or dynamic-stack-buffer-overflow in spider_db_mbase_util::append_table
- Closed
-
MDEV-30392 Syntax error upon query with subquery from Spider table
- Closed
-
MDEV-31645 Spider doesn't recognize semi JOIN
- Closed
-
MDEV-33197 SIGSEGV and UBSAN member access [within/on] null pointer in spider_db_get_row_from_tmp_tbl, Assertion in spider_db_errorno and SIGSEGV in spider_db_store_result
- Confirmed