Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-27255 Delete variables, deprecated by MDEV-27228, and related code
  3. MDEV-27256

Delete spider_use_handler and related code

Details

    Description

      Delete the variable and unused code paths.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29947 Spider doesn't return all rows when doing a join of two tables with no usable keys

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          is blocked by

          Technical task - A technical task. MDEV-27923 Deprecate spider_use_handler

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - - edited

            holyfoot I divided my fix into a series of patches for ease of review. Please check the most recent three patches in the branch. https://github.com/MariaDB/server/tree/bb-10.10-MDEV-27256

            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - - edited holyfoot I divided my fix into a series of patches for ease of review. Please check the most recent three patches in the branch. https://github.com/MariaDB/server/tree/bb-10.10-MDEV-27256
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment -

            Thank you for your review and suggestion. I'd like to keep the code as is because the formatting is mostly done by clang-format-diff and I believe it is a good practice to just use a formatter without manual formatting.

            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - Thank you for your review and suggestion. I'd like to keep the code as is because the formatting is mostly done by clang-format-diff and I believe it is a good practice to just use a formatter without manual formatting.

            People

              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.