Details

    Description

      These features were deprecated in now-EOL versions and can be removed:

      feature was first deprecated in
      @@debug 5.5.37
      @@max_tmp_tables 10.1.2
      "engine_condition_pushdown" in the @@optimizer_switch 10.1.1
      @@date_format 10.1.2
      @@datetime_format 10.1.2
      @@time_format 10.1.2
      @@wsrep_causal_reads 10.1.3
      sr_YU locale 10.0.11
      "parser" in mroonga table comment 10.2.11

      additionally --thread_concurrency was already removed long ago, but left some dead code around

      Attachments

        Activity

          lstartseva Lena Startseva added a comment - - edited

          I’m not sure that these tests are up-to-date and run on some environment, but I think they also need to be corrected:

          @@max_tmp_tables
          in diff: mysql-test/suite/sys_vars/r/sysvars_server_notembedded,32bit.rdiff
          in diff: mysql-test/suite/sys_vars/r/sysvars_server_embedded,32bit.rdiff

          "engine_condition_pushdown" in the @@optimizer_switch
          storage/rocksdb/mysql-test/rocksdb/t/type_char_indexes.test
          mysql-test/suite/storage_engine/type_char_indexes.test
          mysql-test/suite/engines/rr_trx/include/rr_init.test
          in diff: storage/myisammrg/mysql-test/storage_engine/type_char_indexes.rdiff

          @@wsrep_causal_reads:
          In_ sql/wsrep_mysqld.cc_ there is a message "Please unset wsrep_causal_reads variable". If this code is still in use, the error message needs to be changed

          sr_YU locale:
          It looks like this part of the code in sql/sql_locale.cc also needs to be removed:

          MY_LOCALE my_locale_sr_YU /* Deprecated, use sr_RS instead */
          (
            48,
            "sr_YU",
            "Serbian - Yugoslavia",
            FALSE,
            &my_locale_typelib_month_names_sr_RS,
            &my_locale_typelib_ab_month_names_sr_RS,
            &my_locale_typelib_day_names_sr_RS,
            &my_locale_typelib_ab_day_names_sr_RS,
            9,
            10,
            '.',        /* decimal point sr_RS */
            '\0',       /* thousands_sep sr_RS */
            "\x80",     /* grouping      sr_RS */
            &global_errmsgs[sr_RS]
          );
          

          serg, plz, сheck which items really require correction

          lstartseva Lena Startseva added a comment - - edited I’m not sure that these tests are up-to-date and run on some environment, but I think they also need to be corrected: @@max_tmp_tables in diff: mysql-test/suite/sys_vars/r/sysvars_server_notembedded,32bit.rdiff in diff: mysql-test/suite/sys_vars/r/sysvars_server_embedded,32bit.rdiff "engine_condition_pushdown" in the @@optimizer_switch storage/rocksdb/mysql-test/rocksdb/t/type_char_indexes.test mysql-test/suite/storage_engine/type_char_indexes.test mysql-test/suite/engines/rr_trx/include/rr_init.test in diff: storage/myisammrg/mysql-test/storage_engine/type_char_indexes.rdiff @@wsrep_causal_reads: In_ sql/wsrep_mysqld.cc_ there is a message "Please unset wsrep_causal_reads variable". If this code is still in use, the error message needs to be changed sr_YU locale: It looks like this part of the code in sql/sql_locale.cc also needs to be removed: MY_LOCALE my_locale_sr_YU /* Deprecated, use sr_RS instead */ ( 48, "sr_YU", "Serbian - Yugoslavia", FALSE, &my_locale_typelib_month_names_sr_RS, &my_locale_typelib_ab_month_names_sr_RS, &my_locale_typelib_day_names_sr_RS, &my_locale_typelib_ab_day_names_sr_RS, 9, 10, '.', /* decimal point sr_RS */ '\0', /* thousands_sep sr_RS */ "\x80", /* grouping sr_RS */ &global_errmsgs[sr_RS] ); serg , plz, сheck which items really require correction

          fixed, thanks

          serg Sergei Golubchik added a comment - fixed, thanks

          Testing done, OK to push

          lstartseva Lena Startseva added a comment - Testing done, OK to push

          People

            serg Sergei Golubchik
            serg Sergei Golubchik
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.