[MDEV-32104] remove deprecated features Created: 2023-09-05  Updated: 2023-10-01  Resolved: 2023-10-01

Status: Closed
Project: MariaDB Server
Component/s: Variables
Fix Version/s: 11.3.1

Type: Task Priority: Critical
Reporter: Sergei Golubchik Assignee: Sergei Golubchik
Resolution: Fixed Votes: 0
Labels: Preview_11.3

Issue Links:
PartOf

 Description   

These features were deprecated in now-EOL versions and can be removed:

feature was first deprecated in
@@debug 5.5.37
@@max_tmp_tables 10.1.2
"engine_condition_pushdown" in the @@optimizer_switch 10.1.1
@@date_format 10.1.2
@@datetime_format 10.1.2
@@time_format 10.1.2
@@wsrep_causal_reads 10.1.3
sr_YU locale 10.0.11
"parser" in mroonga table comment 10.2.11

additionally --thread_concurrency was already removed long ago, but left some dead code around

 Comments   
Comment by Lena Startseva [ 2023-09-26 ]

I’m not sure that these tests are up-to-date and run on some environment, but I think they also need to be corrected:

@@max_tmp_tables
in diff: mysql-test/suite/sys_vars/r/sysvars_server_notembedded,32bit.rdiff
in diff: mysql-test/suite/sys_vars/r/sysvars_server_embedded,32bit.rdiff

"engine_condition_pushdown" in the @@optimizer_switch
storage/rocksdb/mysql-test/rocksdb/t/type_char_indexes.test
mysql-test/suite/storage_engine/type_char_indexes.test
mysql-test/suite/engines/rr_trx/include/rr_init.test
in diff: storage/myisammrg/mysql-test/storage_engine/type_char_indexes.rdiff

@@wsrep_causal_reads:
In_ sql/wsrep_mysqld.cc_ there is a message "Please unset wsrep_causal_reads variable". If this code is still in use, the error message needs to be changed

sr_YU locale:
It looks like this part of the code in sql/sql_locale.cc also needs to be removed:

MY_LOCALE my_locale_sr_YU /* Deprecated, use sr_RS instead */
 
(
 
  48,
 
  "sr_YU",
 
  "Serbian - Yugoslavia",
 
  FALSE,
 
  &my_locale_typelib_month_names_sr_RS,
 
  &my_locale_typelib_ab_month_names_sr_RS,
 
  &my_locale_typelib_day_names_sr_RS,
 
  &my_locale_typelib_ab_day_names_sr_RS,
 
  9,
 
  10,
 
  '.',        /* decimal point sr_RS */
 
  '\0',       /* thousands_sep sr_RS */
 
  "\x80",     /* grouping      sr_RS */
 
  &global_errmsgs[sr_RS]
 
);

serg, plz, сheck which items really require correction

Comment by Sergei Golubchik [ 2023-09-27 ]

fixed, thanks

Comment by Lena Startseva [ 2023-09-27 ]

Testing done, OK to push

Generated at Thu Feb 08 10:28:51 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.