Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-31807

START SLAVE ,,,,,, is accepted as valid syntax

    XMLWordPrintable

Details

    Description

      MariaDB [test]> START SLAVE ,,,,,,;
      Query OK, 0 rows affected, 1 warning (0.000 sec)
      

      The same also seems to apply to STOP SLAVE.

      Looking at the code, we see that the syntax for it is defined as follows:

      slave_thread_opt_list:
                slave_thread_opt
      	| slave_thread_opt_list ',' slave_thread_opt
      	;
       
      slave_thread_opt:
                /*empty*/ {}
              | SQL_THREAD   { Lex->slave_thd_opt|=SLAVE_SQL; }
              | RELAY_THREAD { Lex->slave_thd_opt|=SLAVE_IO; }
              ;
      

      I believe the empty value should be in slave_thread_opt_list and not in slave_thread_opt; this way an empty value or a list of SQL or IO thread variables is accepted.

      Attachments

        Activity

          People

            Unassigned Unassigned
            markus makela markus makela
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.