Details
-
Technical task
-
Status: Closed (View Workflow)
-
Critical
-
Resolution: Fixed
-
None
-
None
Description
Based on the complexity of the code around spider_casual_read, I would suggest targetting at least 11.4 as the fixversion.
Attachments
Issue Links
- relates to
-
MDEV-28861 Spider: Deprecate table options by COMMENT
-
- Closed
-
-
-
- Closed
-
-
DOCSCOLLAB-170 Failed to load
Activity
Hi Roel, ptal thanks (rebased on current 11.5):
0e2beea1eef bb-11.5-mdev-31789 MDEV-31789 Deprecate spider_casual_read
|
As a general observation only, please note that -1 is the only option that gives a double warning, and the description is not correct (should be 'fallback to table def').
|
11.5.0 0e2beea1eef4ec03eac4ea781852e133397954c3 (Optimized) |
11.5.0-opt>SET GLOBAL spider_casual_read=-1;
|
Query OK, 0 rows affected, 2 warnings (0.000 sec)
|
|
|
11.5.0-opt>SHOW WARNINGS;
|
+---------+------+-------------------------------------------------------------------------------------------------+
|
| Level | Code | Message |
|
+---------+------+-------------------------------------------------------------------------------------------------+
|
| Warning | 1287 | '@@spider_casual_read' is deprecated and will be removed in a future release |
|
| Warning | 138 | The option value -1 (fallback to default) is deprecated and will be removed in a future release |
|
+---------+------+-------------------------------------------------------------------------------------------------+
|
2 rows in set (0.000 sec)
|
(A previous deprecation in progress perhaps)
OK to push.
I've also used the opportunity to start a new full spider testrun (using this branch), bugs will be logged separately.
Thanks Roel. Pushed 593392ba8b70216025fe2adf3eac6330886e2c8b to 11.5.
Fallback to default is correct, because the only default values for these system variables and the corresponding table parameters (if exists) are the default system variable values. There's no default table value.
Hi holyfoot, ptal thanks
upstream/bb-11.5-mdev-31789 3aa5e6e11d646e8ba8c5436490c9dac64930117cMDEV-31789 Deprecate spider_casual_readThe corresponding table param was deprecated as part of MDEV-28861