Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-27228 Deprecate Spider plugin variables that result in excessive tweak
  3. MDEV-31789

Deprecate spider_casual_read

Details

    Description

      Based on the complexity of the code around spider_casual_read, I would suggest targetting at least 11.4 as the fixversion.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-28861 Spider: Deprecate table options by COMMENT

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-26151 Documentation on spider_casual_read is insufficient/non-existing

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          DOCSCOLLAB-170 Failed to load

          Activity

            Ascending order - Click to sort in descending order
            ycp Yuchen Pei added a comment -

            Hi holyfoot, ptal thanks

            upstream/bb-11.5-mdev-31789 3aa5e6e11d646e8ba8c5436490c9dac64930117c
            		 
            MDEV-31789 Deprecate spider_casual_read
            		 
             
            		 
            The corresponding table param was deprecated as part of MDEV-28861

            ycp Yuchen Pei added a comment - Hi holyfoot , ptal thanks upstream/bb-11.5-mdev-31789 3aa5e6e11d646e8ba8c5436490c9dac64930117c MDEV-31789 Deprecate spider_casual_read   The corresponding table param was deprecated as part of MDEV-28861
            holyfoot Alexey Botchkov added a comment -

            ok to push.

            holyfoot Alexey Botchkov added a comment - ok to push.
            ycp Yuchen Pei added a comment -

            Hi Roel, ptal thanks (rebased on current 11.5):

            0e2beea1eef bb-11.5-mdev-31789 MDEV-31789 Deprecate spider_casual_read

            ycp Yuchen Pei added a comment - Hi Roel , ptal thanks (rebased on current 11.5): 0e2beea1eef bb-11.5-mdev-31789 MDEV-31789 Deprecate spider_casual_read
            Roel Roel Van de Paar added a comment - - edited

            As a general observation only, please note that -1 is the only option that gives a double warning, and the description is not correct (should be 'fallback to table def').

            11.5.0 0e2beea1eef4ec03eac4ea781852e133397954c3 (Optimized)

            		 
            11.5.0-opt>SET GLOBAL spider_casual_read=-1;
            		 
            Query OK, 0 rows affected, 2 warnings (0.000 sec)
            		 
             
            		 
            11.5.0-opt>SHOW WARNINGS;
            		 
            +---------+------+-------------------------------------------------------------------------------------------------+
            		 
            | Level   | Code | Message                                                                                         |
            		 
            +---------+------+-------------------------------------------------------------------------------------------------+
            		 
            | Warning | 1287 | '@@spider_casual_read' is deprecated and will be removed in a future release                    |
            		 
            | Warning |  138 | The option value -1 (fallback to default) is deprecated and will be removed in a future release |
            		 
            +---------+------+-------------------------------------------------------------------------------------------------+
            		 
            2 rows in set (0.000 sec)

            (A previous deprecation in progress perhaps)

            Roel Roel Van de Paar added a comment - - edited As a general observation only , please note that -1 is the only option that gives a double warning, and the description is not correct (should be 'fallback to table def'). 11.5.0 0e2beea1eef4ec03eac4ea781852e133397954c3 (Optimized) 11.5.0-opt>SET GLOBAL spider_casual_read=-1; Query OK, 0 rows affected, 2 warnings (0.000 sec)   11.5.0-opt>SHOW WARNINGS; +---------+------+-------------------------------------------------------------------------------------------------+ | Level | Code | Message | +---------+------+-------------------------------------------------------------------------------------------------+ | Warning | 1287 | '@@spider_casual_read' is deprecated and will be removed in a future release | | Warning | 138 | The option value -1 (fallback to default) is deprecated and will be removed in a future release | +---------+------+-------------------------------------------------------------------------------------------------+ 2 rows in set (0.000 sec) (A previous deprecation in progress perhaps)
            Roel Roel Van de Paar added a comment -

            OK to push.
            I've also used the opportunity to start a new full spider testrun (using this branch), bugs will be logged separately.

            Roel Roel Van de Paar added a comment - OK to push. I've also used the opportunity to start a new full spider testrun (using this branch), bugs will be logged separately.
            ycp Yuchen Pei added a comment - - edited

            Thanks Roel. Pushed 593392ba8b70216025fe2adf3eac6330886e2c8b to 11.5.

            Fallback to default is correct, because the only default values for these system variables and the corresponding table parameters (if exists) are the default system variable values. There's no default table value.

            ycp Yuchen Pei added a comment - - edited Thanks Roel . Pushed 593392ba8b70216025fe2adf3eac6330886e2c8b to 11.5. Fallback to default is correct, because the only default values for these system variables and the corresponding table parameters (if exists) are the default system variable values. There's no default table value.

            People

              ycp Yuchen Pei
              ycp Yuchen Pei
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.