Details
-
Task
-
Status: Closed (View Workflow)
-
Blocker
-
Resolution: Fixed
Description
Using mariabackup with the --innobackupex switch should print a deprecation warning ER_WARN_DEPRECATED_SYNTAX or ER_WARN_DEPRECATED_SYNTAX_NO_REPLACEMENT.
Also, mariadb-backup --innobackupex prints a wrong warning:
--innobackupex: Deprecated program name.
|
It will be removed in a future release,
|
use '/path/to/mariadb-backup' instead
|
It's generated in my_init() which incorrectly thinks that the program name is --innobackupex rather than mariadb-backup.
Let's remove this warning.
Attachments
Issue Links
- blocks
-
MDEV-20552 Remove innobackupex mode from Mariabackup
-
- Stalled
-
- relates to
-
MDEV-32253 impossible to use --no-timestamp option
-
- Open
-
Activity
code-wise 855ad7484e0c is ok to push.
I recommend to clarify the test comment before pushing though
it seems something is wrong with command line processing:
if '--innobackupex' is at the end of command line mariadb-backup gives `unknown option` error:
ubuntu@ip-10-1-0-196:~$ sudo mariadb-11.3.0-preview-linux-systemd-x86_64/bin/mariadb-backup -utest_user -pct570c3521fCCR# --target-dir=backup/base_backup_dir --backup --innobackupex
|
mariadb-11.3.0-preview-linux-systemd-x86_64/bin/mariadb-backup: unknown option '--innobackupex'
|
|
if '--innobackupex' is the first argument mariadb-backup gives `Missing argument` error:
ubuntu@ip-10-1-0-196:~$ sudo mariadb-11.3.0-preview-linux-systemd-x86_64/bin/mariadb-backup --innobackupex -utest_user -pct570c3521fCCR# --target-dir=backup/base_backup_dir
|
230921 13:10:55 innobackupex: Missing argument
|
|
tested with https://mirrors.xtom.ee/mariadb//mariadb-11.3.0/bintar-linux-systemd-x86_64/mariadb-11.3.0-preview-linux-systemd-x86_64.tar.gz and Ubuntu Focal
Hello serg. Can you please review this patch:
https://github.com/MariaDB/server/commit/855ad7484e0c3148c9f0858842aaa60deceb8240
?
Thanks.