[MDEV-31505] Deprecate mariabackup --innobackupex mode Created: 2023-06-20  Updated: 2023-09-26  Resolved: 2023-09-04

Status: Closed
Project: MariaDB Server
Component/s: Backup
Fix Version/s: 11.3.0

Type: Task Priority: Blocker
Reporter: Sergei Golubchik Assignee: Alexander Barkov
Resolution: Fixed Votes: 0
Labels: Preview_11.3

Issue Links:
Blocks
blocks MDEV-20552 Remove innobackupex mode from Mariaba... Stalled
PartOf
Relates
relates to MDEV-32253 impossible to use --no-timestamp option Open

 Description   

Using mariabackup with the --innobackupex switch should print a deprecation warning ER_WARN_DEPRECATED_SYNTAX or ER_WARN_DEPRECATED_SYNTAX_NO_REPLACEMENT.

Also, mariadb-backup --innobackupex prints a wrong warning:

--innobackupex: Deprecated program name.
 
It will be removed in a future release,
 
use '/path/to/mariadb-backup' instead

It's generated in my_init() which incorrectly thinks that the program name is --innobackupex rather than mariadb-backup.
Let's remove this warning.

 Comments   
Comment by Alexander Barkov [ 2023-08-31 ]

Hello serg. Can you please review this patch:

https://github.com/MariaDB/server/commit/855ad7484e0c3148c9f0858842aaa60deceb8240

?

Thanks.

Comment by Sergei Golubchik [ 2023-08-31 ]

code-wise 855ad7484e0c is ok to push.

I recommend to clarify the test comment before pushing though

Comment by Timofey Turenko [ 2023-09-21 ]

it seems something is wrong with command line processing:

if '--innobackupex' is at the end of command line mariadb-backup gives `unknown option` error:

ubuntu@ip-10-1-0-196:~$ sudo mariadb-11.3.0-preview-linux-systemd-x86_64/bin/mariadb-backup  -utest_user -pct570c3521fCCR#  --target-dir=backup/base_backup_dir --backup --innobackupex
 
mariadb-11.3.0-preview-linux-systemd-x86_64/bin/mariadb-backup: unknown option '--innobackupex'

if '--innobackupex' is the first argument mariadb-backup gives `Missing argument` error:

ubuntu@ip-10-1-0-196:~$ sudo mariadb-11.3.0-preview-linux-systemd-x86_64/bin/mariadb-backup  --innobackupex -utest_user -pct570c3521fCCR#  --target-dir=backup/base_backup_dir
 
230921 13:10:55 innobackupex: Missing argument

tested with https://mirrors.xtom.ee/mariadb//mariadb-11.3.0/bintar-linux-systemd-x86_64/mariadb-11.3.0-preview-linux-systemd-x86_64.tar.gz and Ubuntu Focal

Generated at Thu Feb 08 10:24:23 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.