Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-31331

preinst broken due to unset variable

Details

    Description

      Commit fe32a4a broke `debian/mariadb-server.preinst`, which causes the following error on install and upgrade. Tested with upgrade from 10.6.12 to 10.6.13.

      df: '': No such file or directory
      /var/lib/dpkg/tmp.ci/preinst: line 215: [: : integer expression expected
      

      The `df` command (on line 201 in the 11.1 branch) refers to the unset variable `$datadir`. The variable that is set is `$mysql_datadir`.

      Attachments

        Issue Links

          Activity

            wedwards William Edwards created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            Affects Version/s 10.6.13 [ 28514 ]
            Assignee Tuukka Pasanen [ JIRAUSER49166 ]
            illuusio Tuukka Pasanen made changes -
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.8 [ 26121 ]
            Fix Version/s 10.9 [ 26905 ]
            Fix Version/s 10.10 [ 27530 ]
            Fix Version/s 10.11 [ 27614 ]
            Fix Version/s 11.0 [ 28320 ]
            Fix Version/s 11.1 [ 28549 ]
            illuusio Tuukka Pasanen made changes -
            Status Open [ 1 ] In Progress [ 3 ]

            Thank you for reporting this! Corrected cut'n'paste problem and I'll make shortly PR that should sort this out.

            illuusio Tuukka Pasanen added a comment - Thank you for reporting this! Corrected cut'n'paste problem and I'll make shortly PR that should sort this out.
            wedwards William Edwards added a comment - - edited

            @illuusio Perhaps it would be useful to use `set -u` to prevent such mistakes in the future.

            wedwards William Edwards added a comment - - edited @illuusio Perhaps it would be useful to use `set -u` to prevent such mistakes in the future.

            Very good point indeed and yes I think it would be nice add. Could you open JIRA task for that and point it to me?

            Besides that here are Salsa-CI (they should be ok with Debian 12) builded debs that should fix issue. I'll give them testing and commit PR if they are ok. If you have docker or similar to test could you also give them a try?

            illuusio Tuukka Pasanen added a comment - Very good point indeed and yes I think it would be nice add. Could you open JIRA task for that and point it to me? Besides that here are Salsa-CI (they should be ok with Debian 12) builded debs that should fix issue. I'll give them testing and commit PR if they are ok. If you have docker or similar to test could you also give them a try?

            But actually you can't test MariaDB 10.6 on Debian 12 so I'll make a PR soon which builds correct debs

            illuusio Tuukka Pasanen added a comment - But actually you can't test MariaDB 10.6 on Debian 12 so I'll make a PR soon which builds correct debs
            wedwards William Edwards made changes -

            Created Jira issue MDEV-31367.

            wedwards William Edwards added a comment - Created Jira issue MDEV-31367 .

            Thanks now there is PR: #2650

            illuusio Tuukka Pasanen added a comment - Thanks now there is PR: #2650
            illuusio Tuukka Pasanen made changes -
            Status In Progress [ 3 ] Needs Feedback [ 10501 ]
            danblack Daniel Black added a comment -

            good

            danblack Daniel Black added a comment - good
            danblack Daniel Black made changes -
            Status Needs Feedback [ 10501 ] Open [ 1 ]
            danblack Daniel Black made changes -
            Fix Version/s 11.1.1 [ 28704 ]
            Fix Version/s 10.6.14 [ 28914 ]
            Fix Version/s 10.9.7 [ 28916 ]
            Fix Version/s 10.10.5 [ 28917 ]
            Fix Version/s 10.11.4 [ 28918 ]
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.8 [ 26121 ]
            Fix Version/s 10.9 [ 26905 ]
            Fix Version/s 10.10 [ 27530 ]
            Fix Version/s 10.11 [ 27614 ]
            Fix Version/s 11.0 [ 28320 ]
            Fix Version/s 11.1 [ 28549 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            danblack Daniel Black made changes -
            danblack Daniel Black made changes -
            danblack Daniel Black made changes -
            dbart Daniel Bartholomew made changes -
            Fix Version/s 10.6.15 [ 29013 ]
            Fix Version/s 10.9.8 [ 29015 ]
            Fix Version/s 10.10.6 [ 29017 ]
            Fix Version/s 10.11.5 [ 29019 ]
            Fix Version/s 11.1.2 [ 28921 ]
            Fix Version/s 11.1.1 [ 28704 ]
            Fix Version/s 10.6.14 [ 28914 ]
            Fix Version/s 10.9.7 [ 28916 ]
            Fix Version/s 10.10.5 [ 28917 ]
            Fix Version/s 10.11.4 [ 28918 ]

            People

              illuusio Tuukka Pasanen
              wedwards William Edwards
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.