Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-31331

preinst broken due to unset variable

Details

    Description

      Commit fe32a4a broke `debian/mariadb-server.preinst`, which causes the following error on install and upgrade. Tested with upgrade from 10.6.12 to 10.6.13.

      df: '': No such file or directory
      		 
      /var/lib/dpkg/tmp.ci/preinst: line 215: [: : integer expression expected

      The `df` command (on line 201 in the 11.1 branch) refers to the unset variable `$datadir`. The variable that is set is `$mysql_datadir`.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31423 /etc/init.d/mariadb: line 90: [: : integer expression expected

          • Major - Major loss of function.
          • Closed
          split to

          Task - A task that needs to be done. MDEV-31367 Fail on undefined variables in Debian scripts

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            illuusio Tuukka Pasanen added a comment -

            Thank you for reporting this! Corrected cut'n'paste problem and I'll make shortly PR that should sort this out.

            illuusio Tuukka Pasanen added a comment - Thank you for reporting this! Corrected cut'n'paste problem and I'll make shortly PR that should sort this out.
            wedwards William David Edwards added a comment - - edited

            @illuusio Perhaps it would be useful to use `set -u` to prevent such mistakes in the future.

            wedwards William David Edwards added a comment - - edited @illuusio Perhaps it would be useful to use `set -u` to prevent such mistakes in the future.
            illuusio Tuukka Pasanen added a comment -

            Very good point indeed and yes I think it would be nice add. Could you open JIRA task for that and point it to me?

            Besides that here are Salsa-CI (they should be ok with Debian 12) builded debs that should fix issue. I'll give them testing and commit PR if they are ok. If you have docker or similar to test could you also give them a try?

            illuusio Tuukka Pasanen added a comment - Very good point indeed and yes I think it would be nice add. Could you open JIRA task for that and point it to me? Besides that here are Salsa-CI (they should be ok with Debian 12) builded debs that should fix issue. I'll give them testing and commit PR if they are ok. If you have docker or similar to test could you also give them a try?
            illuusio Tuukka Pasanen added a comment -

            But actually you can't test MariaDB 10.6 on Debian 12 so I'll make a PR soon which builds correct debs

            illuusio Tuukka Pasanen added a comment - But actually you can't test MariaDB 10.6 on Debian 12 so I'll make a PR soon which builds correct debs
            wedwards William David Edwards added a comment -

            Created Jira issue MDEV-31367.

            wedwards William David Edwards added a comment - Created Jira issue MDEV-31367 .
            illuusio Tuukka Pasanen added a comment -

            Thanks now there is PR: #2650

            illuusio Tuukka Pasanen added a comment - Thanks now there is PR: #2650
            danblack Daniel Black added a comment -

            good

            danblack Daniel Black added a comment - good

            People

              illuusio Tuukka Pasanen
              wedwards William David Edwards
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.