Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30422

Merge new release of InnoDB 5.7.41 to 10.3

Details

    Description

      MySQL 5.7.41 includes the following InnoDB changes:

      Not applicable to MariaDB Server

      Bug #33822493 : pb2 weekly-5.7 test failures due to InnoDB: Assertion failure
      This race condition was fixed in MDEV-12024 in February 2017.

      Applicable to MariaDB Server

      Bug#34400586 Backport MySQL contribution id: 31497 to 5.7
      The commit message appears to refer to this change in MySQL 8.0.
      This aims to prevent a last-minute dirtying of the buffer pool due to a change buffer merge. In MariaDB Server 10.5, not only was the buf_flush_page_cleaner() thread refactored, but also MDEV-19514 should prevent any change buffer merge from occurring at this point.
      I believe that the Oracle internal bug report was similar to MDEV-20481, which turns out to have been fixed by MDEV-24448 and MDEV-24449.

      All that said, something like this fix should be applicable to MariaDB 10.3 and 10.4, to prevent a very rare condition where read-ahead of a secondary index leaf page had been submitted during or right before shutdown. As always (see MDEV-30009), it is very hard to reproduce any bugs in the change buffer.

      Attachments

        Issue Links

          Activity

            marko Marko Mäkelä created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            marko Marko Mäkelä made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            Description MySQL 5.7.41 includes the following InnoDB changes:
            h2. Not applicable to MariaDB Server
            [Bug #33822493 : pb2 weekly-5.7 test failures due to InnoDB: Assertion failure|https://github.com/mysql/mysql-server/commit/5005d02ed47183bd643c057f5f4b0ace0e9a1553]
            This race condition was fixed in MDEV-12024 in February 2017.
            h2. Applicable to MariaDB Server
            [Bug#34400586 Backport MySQL contribution id: 31497 to 5.7|https://github.com/mysql/mysql-server/commit/d2d6b2dd00f709bc528386009150d4bc726e25a0]
            The commit message appears to refer to [this change in MySQL 8.0|https://github.com/mysql/mysql-server/commit/716001c5011e99dd00838398dd20f06a500ef26c].
            This resembles our fix of MDEV-24449. It aims to prevent a last-minute dirtying of the buffer pool due to a change buffer merge. In MariaDB Server 10.5, not only was the {{buf_flush_page_cleaner()}} thread refactored, but also MDEV-19514 should prevent any change buffer merge from occurring at this point. This fix should be applicable to MariaDB 10.3 and 10.4.
            MySQL 5.7.41 includes the following InnoDB changes:
            h2. Not applicable to MariaDB Server
            [Bug #33822493 : pb2 weekly-5.7 test failures due to InnoDB: Assertion failure|https://github.com/mysql/mysql-server/commit/5005d02ed47183bd643c057f5f4b0ace0e9a1553]
            This race condition was fixed in MDEV-12024 in February 2017.
            h2. Applicable to MariaDB Server
            [Bug#34400586 Backport MySQL contribution id: 31497 to 5.7|https://github.com/mysql/mysql-server/commit/d2d6b2dd00f709bc528386009150d4bc726e25a0]
            The commit message appears to refer to [this change in MySQL 8.0|https://github.com/mysql/mysql-server/commit/716001c5011e99dd00838398dd20f06a500ef26c].
            This aims to prevent a last-minute dirtying of the buffer pool due to a change buffer merge. In MariaDB Server 10.5, not only was the {{buf_flush_page_cleaner()}} thread refactored, but also MDEV-19514 should prevent any change buffer merge from occurring at this point.
            I believe that the Oracle internal bug report was similar to MDEV-20481, which turns out to have been fixed by MDEV-24448 and MDEV-24449.

            All that said, something like this fix should be applicable to MariaDB 10.3 and 10.4, to prevent a very rare condition where read-ahead of a secondary index leaf page had been submitted during or right before shutdown. As always (see MDEV-30009), it is very hard to reproduce any bugs in the change buffer.
            marko Marko Mäkelä made changes -
            issue.field.resolutiondate 2023-01-17 17:05:43.0 2023-01-17 17:05:43.88
            marko Marko Mäkelä made changes -
            Fix Version/s 10.3.38 [ 28507 ]
            Fix Version/s 10.4.28 [ 28509 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            marko Marko Mäkelä made changes -
            Labels corruption race upstream corruption not-10.5 race upstream
            marko Marko Mäkelä made changes -

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.