Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-29481

mariadb-upgrade prints confusing statement

Details

    Description

      When running mariadb-upgrade it provides confusing statements:

      schema1.table1
      error : Table rebuild required. Please do "ALTER TABLE `table1` FORCE" or dump/reload to fix it!
      schema1.table2 OK
      schema1.table3
      error : Table rebuild required. Please do "ALTER TABLE `table3` FORCE" or dump/reload to fix it!
      schema1.table4 OK
      ...
      `schema1`.`table1` FIXED
      `schema1`.`table4` FIXED

      At the end of the upgrade mariadb-upgrade does the ALTER TABLE FORCE itself. So user does not need to do it.
      So it would be more meaningful to print a message like "Table rebuild required. I do it further down..."

      Customer was confused (an I was as well when reading the first time).

      Would be a good task for a simple community contribution if it will be decided to be implemented...

      Attachments

        Issue Links

          Activity

            oli Oli Sennhauser created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value

            Thank you for the report. I think that we simply need a better fix of MDEV-28727, to actually fix what was requested.

            Demanding a table rebuild when only some metadata (.frm file contents) is in an old format feels excessive to me.

            marko Marko Mäkelä added a comment - Thank you for the report. I think that we simply need a better fix of MDEV-28727 , to actually fix what was requested. Demanding a table rebuild when only some metadata ( .frm file contents) is in an old format feels excessive to me.
            TheLinuxJedi Andrew Hutchings (Inactive) made changes -
            Labels beginner-friendly
            bar Alexander Barkov made changes -
            marko Marko Mäkelä made changes -
            Issue Type Task [ 3 ] Bug [ 1 ]
            marko Marko Mäkelä made changes -
            Component/s Data Definition - Alter Table [ 10114 ]
            Component/s Storage Engine - InnoDB [ 10129 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.7 [ 24805 ]
            Fix Version/s 10.8 [ 26121 ]
            Fix Version/s 10.9 [ 26905 ]
            Fix Version/s 10.10 [ 27530 ]
            Affects Version/s 10.10.1 [ 27913 ]
            Affects Version/s 10.9.2 [ 27115 ]
            Affects Version/s 10.8.4 [ 27503 ]
            Affects Version/s 10.7.5 [ 27505 ]
            Affects Version/s 10.6.9 [ 27507 ]
            Affects Version/s 10.5.17 [ 27509 ]
            Affects Version/s 10.4.26 [ 27511 ]
            Assignee Marko Mäkelä [ marko ]
            Labels beginner-friendly regression-10.4
            Priority Minor [ 4 ] Critical [ 2 ]
            marko Marko Mäkelä made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            danblack Daniel Black made changes -
            Labels regression-10.4 beginner-friendly regression-10.4
            serg Sergei Golubchik made changes -
            marko Marko Mäkelä made changes -
            Assignee Marko Mäkelä [ marko ] Alexander Barkov [ bar ]
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -

            Hello serg. Can you please review patches in this branch:

            https://github.com/mariadb/server/tree/bb-10.4-bar-MDEV-29481

            • The first patch reverts MDEV-28727
            • The second patch fixes the problem with DOUBLE in a new way.

            Thanks.

            bar Alexander Barkov added a comment - Hello serg . Can you please review patches in this branch: https://github.com/mariadb/server/tree/bb-10.4-bar-MDEV-29481 The first patch reverts MDEV-28727 The second patch fixes the problem with DOUBLE in a new way. Thanks.
            bar Alexander Barkov made changes -
            Assignee Alexander Barkov [ bar ] Sergei Golubchik [ serg ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            bar Alexander Barkov made changes -
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Alexander Barkov [ bar ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            bar Alexander Barkov made changes -
            julien.fritsch Julien Fritsch made changes -
            Priority Critical [ 2 ] Blocker [ 1 ]
            serg Sergei Golubchik made changes -
            Labels beginner-friendly regression-10.4 regression-10.4
            serg Sergei Golubchik made changes -
            Priority Blocker [ 1 ] Critical [ 2 ]
            serg Sergei Golubchik made changes -
            Priority Critical [ 2 ] Blocker [ 1 ]
            bar Alexander Barkov added a comment - - edited

            Hello serg. Can you please review a new version of patches in this branch:

            https://github.com/MariaDB/server/commits/bb-10.4-bar-MDEV-29481

            bar Alexander Barkov added a comment - - edited Hello serg . Can you please review a new version of patches in this branch: https://github.com/MariaDB/server/commits/bb-10.4-bar-MDEV-29481 The first patch reverts MDEV-28727 The second patch fixes the problem with DOUBLE in a new way: https://github.com/MariaDB/server/commit/99dcf061c8ca3ae4d1cd2214cebfb7b32950f459
            bar Alexander Barkov made changes -
            Assignee Alexander Barkov [ bar ] Sergei Golubchik [ serg ]
            Status Stalled [ 10000 ] In Review [ 10002 ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Alexander Barkov [ bar ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            bar Alexander Barkov made changes -
            Fix Version/s 10.4.27 [ 28405 ]
            Fix Version/s 10.5.18 [ 28421 ]
            Fix Version/s 10.6.11 [ 28441 ]
            Fix Version/s 10.7.7 [ 28442 ]
            Fix Version/s 10.8.6 [ 28443 ]
            Fix Version/s 10.9.4 [ 28444 ]
            Fix Version/s 10.10.2 [ 28410 ]
            Fix Version/s 10.11.1 [ 28454 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.7 [ 24805 ]
            Fix Version/s 10.8 [ 26121 ]
            Fix Version/s 10.9 [ 26905 ]
            Fix Version/s 10.10 [ 27530 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            rob.schwyzer@mariadb.com Rob Schwyzer (Inactive) made changes -
            rob.schwyzer@mariadb.com Rob Schwyzer (Inactive) made changes -
            rob.schwyzer@mariadb.com Rob Schwyzer (Inactive) made changes -
            rob.schwyzer@mariadb.com Rob Schwyzer (Inactive) made changes -
            rob.schwyzer@mariadb.com Rob Schwyzer (Inactive) made changes -
            rob.schwyzer@mariadb.com Rob Schwyzer (Inactive) made changes -
            rob.schwyzer@mariadb.com Rob Schwyzer (Inactive) made changes -
            rob.schwyzer@mariadb.com Rob Schwyzer (Inactive) made changes -
            rob.schwyzer@mariadb.com Rob Schwyzer (Inactive) made changes -
            mariadb-jira-automation Jira Automation (IT) made changes -
            Zendesk Related Tickets 201658 178392 199385
            Zendesk active tickets 201658

            People

              bar Alexander Barkov
              oli Oli Sennhauser
              Votes:
              1 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.