Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-29481

mariadb-upgrade prints confusing statement

Details

    Description

      When running mariadb-upgrade it provides confusing statements:

      schema1.table1
      error : Table rebuild required. Please do "ALTER TABLE `table1` FORCE" or dump/reload to fix it!
      schema1.table2 OK
      schema1.table3
      error : Table rebuild required. Please do "ALTER TABLE `table3` FORCE" or dump/reload to fix it!
      schema1.table4 OK
      ...
      `schema1`.`table1` FIXED
      `schema1`.`table4` FIXED

      At the end of the upgrade mariadb-upgrade does the ALTER TABLE FORCE itself. So user does not need to do it.
      So it would be more meaningful to print a message like "Table rebuild required. I do it further down..."

      Customer was confused (an I was as well when reading the first time).

      Would be a good task for a simple community contribution if it will be decided to be implemented...

      Attachments

        Issue Links

          Activity

            Thank you for the report. I think that we simply need a better fix of MDEV-28727, to actually fix what was requested.

            Demanding a table rebuild when only some metadata (.frm file contents) is in an old format feels excessive to me.

            marko Marko Mäkelä added a comment - Thank you for the report. I think that we simply need a better fix of MDEV-28727 , to actually fix what was requested. Demanding a table rebuild when only some metadata ( .frm file contents) is in an old format feels excessive to me.

            Hello serg. Can you please review patches in this branch:

            https://github.com/mariadb/server/tree/bb-10.4-bar-MDEV-29481

            • The first patch reverts MDEV-28727
            • The second patch fixes the problem with DOUBLE in a new way.

            Thanks.

            bar Alexander Barkov added a comment - Hello serg . Can you please review patches in this branch: https://github.com/mariadb/server/tree/bb-10.4-bar-MDEV-29481 The first patch reverts MDEV-28727 The second patch fixes the problem with DOUBLE in a new way. Thanks.
            bar Alexander Barkov added a comment - - edited

            Hello serg. Can you please review a new version of patches in this branch:

            https://github.com/MariaDB/server/commits/bb-10.4-bar-MDEV-29481

            bar Alexander Barkov added a comment - - edited Hello serg . Can you please review a new version of patches in this branch: https://github.com/MariaDB/server/commits/bb-10.4-bar-MDEV-29481 The first patch reverts MDEV-28727 The second patch fixes the problem with DOUBLE in a new way: https://github.com/MariaDB/server/commit/99dcf061c8ca3ae4d1cd2214cebfb7b32950f459

            People

              bar Alexander Barkov
              oli Oli Sennhauser
              Votes:
              1 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.